Merge release/3.7 to master #3282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://www.contributor-covenant.org/ `You must add a contact method to the placeholder in the document so that people know how to report violations.`
chore: update code of conduct to 2.1
This reverts commit 258ec46
This reverts commit 552d9a8
This reverts commit 924a715
Telegram workflow update
Remove play & fdroid release builds
Upgrade Robolectric to 4.7
Bugfix/status bar color
…x-subpath Fix SSHConnectionPool with subdirectories in URI
…erence Fix columns for grid layout for MainFragment
Integrate amaze utils transfer and analyse in navigation drawer
Fix cloud properties dialog crash
Transifex translations
|
@TranceLove can you look at the failing emulator test please |
Our lowest supported version is SDK 14, while SecretKeygen.getSecretKey() lowest supported is SDK 18. This changes verification to allow nulls to pass through for devices lower than API 18. Still throw failure if using devices below SDK 14.
2 tasks
|
@VishalNehra Please merge #3284 and try this again. |
|
@TranceLove Thanks |
Fix Robolectric test failure
At SDK < 18, no AES key can be obtained from keystore, hence causing CryptUtilEspressoTest.testEncryptDecryptLegacyMethod() to fail. This fixes the problem by adding quirk to ensure plain I/O is still in place without causing crashes.
2 tasks
Fix CryptUtil behaviour for SDK < 18
3 tasks
Third in the series. :(
Fix CryptUtilEspressoTest and UtilsHandlerTests failures on new Androids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue tracker
Automatic tests
Manual tests
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck