Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bestiary GUI Bug Fixes (Note: need to check in new artifacts?) #48

Merged
merged 1 commit into from
Sep 9, 2023

Conversation

aaronkwan
Copy link
Collaborator

  • Hide attributes for Bestiary Areas and Bestiary Souls (fixes bug #9123)
  • Cap damage stat at minimum 0 (fixes bug #10204)
  • Hide potion attributes for damage stat icon (fixes bug #12997)

- Hide attributes for Bestiary Areas and Bestiary Souls (fixes bug #9123)
- Cap damage stat at minimum 0 (fixes bug #10204)
- Hide potion attributes for damage stat icon (fixes bug #12997)
@aaronkwan aaronkwan requested a review from Combustible August 28, 2023 02:20
@aaronkwan
Copy link
Collaborator Author

@Combustible I'm not entirely sure how to check in new artifacts for these changes so I'm leaving them untouched. Let's check back after the whole 1.19 upgrade!

Copy link
Collaborator

@Combustible Combustible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! No need to update the artifacts, the API didn't change.

@Combustible Combustible merged commit f040bb7 into master Sep 9, 2023
4 checks passed
@Combustible Combustible deleted the zy-bestiary-bug-fixes-and-1.19-upgrade branch September 9, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants