Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated returnActivity test code #11428

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

Two-Ai
Copy link
Contributor

@Two-Ai Two-Ai commented Aug 11, 2024

returnActivity was removed in 463dd8e (#5148).

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Remove ErrorActivity.getReturnActivity() (currently only used for tests)
  • Remove ErrorActivityTest (currently only exercises getReturnActivity())

Fixes the following issue(s)

  • Removes dead code.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

returnActivity was removed in 463dd8e
@github-actions github-actions bot added the size/medium PRs with less than 250 changed lines label Aug 11, 2024
@TobiGr TobiGr added the codequality Improvements to the codebase to improve the code quality label Aug 14, 2024
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

sonarcloud bot commented Aug 14, 2024

@TobiGr TobiGr merged commit fad3120 into TeamNewPipe:dev Aug 14, 2024
7 checks passed
@Two-Ai Two-Ai deleted the remove-returnActivity-test branch August 17, 2024 00:02
@Stypox Stypox mentioned this pull request Nov 17, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality size/medium PRs with less than 250 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants