Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] #98 - Splash 로티 구현 #101

Merged
merged 3 commits into from
Jan 18, 2022
Merged

[Feat] #98 - Splash 로티 구현 #101

merged 3 commits into from
Jan 18, 2022

Conversation

hyun99999
Copy link
Member

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • Splash 로티 파일 추가
  • Splash 뷰에서 로티 구현

📌 참고 사항

  • 소셜로그인 곧 하겠습니당

📸 스크린샷

기능 스크린샷
스플래시

📮 관련 이슈

@hyun99999
[Add] TeamSparker#98 - Splash 로티 대체
2f19396
@hyun99999
[Feat] TeamSparker#98 - Splash 로티 구현
db9529f 
- 로티 상수 네이밍 변경
- Login 뷰 배경 scaleAspectFill 로 변경
@hyun99999
[Merge] TeamSparker#98 - Merge branch 'develop' into `feature/TeamSpa…
ccd4b90 
…rker#98`

# Conflicts:
#	Spark-iOS/Spark-iOS.xcodeproj/project.pbxproj
@hyun99999 hyun99999 added Feat 새로운 기능 구현 👼타락pOwEr천사현규 크로아서버 환영요 labels Jan 17, 2022
@hyun99999 hyun99999 self-assigned this Jan 17, 2022
yangsubinn
yangsubinn approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@yangsubinn yangsubinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

왕 로티 두개 쓰인거구나 .. 스플래시 감삼다💐

L-j-h-c
L-j-h-c approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@L-j-h-c L-j-h-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스플래시 로티 넘나 이뻐여 감사합니다...!

@hyun99999 hyun99999 merged commit e88e7e6 into TeamSparker:develop Jan 18, 2022
@hyun99999 hyun99999 deleted the feature/#98 branch January 18, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangsubinn yangsubinn yangsubinn approved these changes

@L-j-h-c L-j-h-c L-j-h-c approved these changes

Assignees

@hyun99999 hyun99999

Labels
Feat 새로운 기능 구현 👼타락pOwEr천사현규 크로아서버 환영요
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] Splash 로티 구현
3 participants
@hyun99999 @L-j-h-c @yangsubinn