[Feat] #155 - 습관방 만들기 화면전환 및 각종 코드 디테일 수정 #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
스위프트 린트 경고문 수정
방만들기 케이스 및 버튼 별 화면 전환 기능 구현
스위프트 린트 코드 수정
인증사진 모아보기 마지막 날짜 미표시 및 REST 분기처리
yangsubinn
approved these changes
Jan 20, 2022
| @@ -34,7 +34,7 @@ class FeedCVC: UICollectionViewCell { | |||
| let likeCountLabel = UILabel() | |||
| let lottieView = AnimationView(name: "icHeartActive") | |||
| var likeState: Bool = false | |||
| var likeDelegate: FeedCellDelegate? | |||
| weak var likeDelegate: FeedCellDelegate? | |||
이미지 익스텐션 및 리사이징 함수 추가
이미지 피커에서 담을 이미지 리사이징
쉴래요 횟수에 따른 버튼 비활성화
hyun99999
approved these changes
Jan 21, 2022
Comment on lines
+51
to
+53
| } else if leftDay == 66 { | ||
| dDayLabel.text = "D-\(leftDay)" | ||
| certificationImage.image = UIImage() |
There was a problem hiding this comment.
66일은 모아보기 서버에서 안넘겨준다고 했지만 혹시 서버에서 잘못줄수도있으니 분기는 처리해둡시당
Comment on lines
+11
to
+18
| func resize(newWidth: CGFloat) -> UIImage { | ||
| let scale = newWidth / self.size.width | ||
| let newHeight = self.size.height * scale | ||
| let size = CGSize(width: newWidth, height: newHeight) | ||
| let render = UIGraphicsImageRenderer(size: size) | ||
| let renderImage = render.image { context in self.draw(in: CGRect(origin: .zero, size: size)) } | ||
| return renderImage | ||
| } |
There was a problem hiding this comment.
호오... newWidth 는 어떤 기준이될까 궁금하네여
| @@ -260,7 +260,7 @@ extension AuthUploadVC: UIImagePickerControllerDelegate, UINavigationControllerD | |||
|
|
|||
| func imagePickerController(_ picker: UIImagePickerController, didFinishPickingMediaWithInfo info: [UIImagePickerController.InfoKey: Any]) { | |||
| if let image = info[UIImagePickerController.InfoKey.originalImage] as? UIImage { | |||
| uploadImageView.image = image | |||
| uploadImageView.image = image.resize(newWidth: 250) | |||
hyun99999
reviewed
Jan 21, 2022
Comment on lines
+116
to
+120
| if myRoomCertificationList?.last?.leftDay == 66 { | ||
| return ((myRoomCertificationList?.count ?? 0) - 1) | ||
| } else { | ||
| return myRoomCertificationList?.count ?? 0 | ||
| } |
Comment on lines
-227
to
-228
| // FIXME: - 아래의 목적인데 한번 체크해야할듯 | ||
| // 성공적으로 한번의 통신이 마무리된 후 무한스크롤 허용. 즉, 연속적으로 통신을 요청하지 않게 하기 위함. |
There was a problem hiding this comment.
요건 fixme 가 필요한 상태라 살려주실 수 있을까여 ㅜ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
📮 관련 이슈