Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] #174 - 로딩뷰 구현 #181

Merged
merged 12 commits into from
Jan 21, 2022
Merged

[Feat] #174 - 로딩뷰 구현 #181

merged 12 commits into from
Jan 21, 2022

Conversation

yangsubinn
Copy link
Member

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • 사진 인증 -> 성공 팝업
  • 피드 (로딩 세팅만)
  • 홈
  • 습관방 상세
  • 보관함

📌 참고 사항

피드에는 로딩뷰와 setLoading 함수만 넣어줬습니다.

📸 스크린샷

기능 스크린샷
GIF 파일첨부바람

📮 관련 이슈

@yangsubinn yangsubinn self-assigned this Jan 21, 2022
@yangsubinn yangsubinn added the Feat 새로운 기능 구현 label Jan 21, 2022
@yangsubinn yangsubinn added the 🦹t없e맑은水빈 우리 선배 이젠 타이니하지 않아 label Jan 21, 2022
L-j-h-c
L-j-h-c approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@L-j-h-c L-j-h-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우리 커밋도 최수종인가요?

hyun99999
hyun99999 approved these changes Jan 21, 2022
View reviewed changes
Spark-iOS/Spark-iOS/Source/ViewControllers/Create/CreateAuthVC.swift Outdated
@@ -88,7 +89,7 @@ class CreateAuthVC: UIViewController {

@objc
private func touchEnterButton() {
postCreateRoomWithAPI(roomName: roomName, fromStart: !photoOnly) {
self.postCreateRoomWithAPI(roomName: self.roomName, fromStart: !self.photoOnly) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요건 self. 없어도 되지 않을까용?

@yangsubinn yangsubinn merged commit 8e9af6f into TeamSparker:develop Jan 21, 2022
@yangsubinn yangsubinn deleted the feature/#174 branch January 27, 2022 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-j-h-c L-j-h-c L-j-h-c approved these changes

@hyun99999 hyun99999 hyun99999 approved these changes

Assignees

@yangsubinn yangsubinn

Labels
Feat 새로운 기능 구현 🦹t없e맑은水빈 우리 선배 이젠 타이니하지 않아
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] 로딩 붙이기
3 participants
@yangsubinn @hyun99999 @L-j-h-c