-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Upgrade gopkg.in/yaml.v2 to gopkg.in/yaml.v3 due to security issue #91
Conversation
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
==========================================
+ Coverage 74.11% 74.18% +0.06%
==========================================
Files 10 10
Lines 1495 1499 +4
==========================================
+ Hits 1108 1112 +4
Misses 279 279
Partials 108 108
Continue to review full report at Codecov.
|
From the security report: > An issue in the Unmarshal function in Go-Yaml v3 causes the program to crash > when attempting to deserialize invalid input. While upgrading to version 3, there was some required changes: * Force the encoder to use 2 spaces for identation * Rewrite tests so lists are idented References: https://nvd.nist.gov/vuln/detail/CVE-2022-28948 go-yaml/yaml#666 GHSA-hp87-p4gw-j4gq
c4fd45c
to
8cea7c5
Compare
Am I misreading the linked issues/reports or was the vulnerability only present in v3 and not v2 (which we're currently using)? Granted it's now fixed in v3 as well, but arguably this wasn't necessary unless we intend to use some v3 features 🤔 |
Yep, you read it right 😄 , the biggest pain is that the Github Alert (for some strange reason) decided to annoy about anything before version 3.0.0: So to get rid of the repository warning, we actually need to upgrade to version 3: |
They just released |
Thanks @ripexz ! Upgraded there now 🙂 |
This is required so all dependencies use yaml.v3.
From the security report:
While upgrading to version 3, there were some required changes:
References:
https://nvd.nist.gov/vuln/detail/CVE-2022-28948
go-yaml/yaml#666
GHSA-hp87-p4gw-j4gq