Give DefaultSignalPayload Public Access
#126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es of DefaultSignalPayload public. Add doc comment on the type.
nevillco
commented
Oct 26, 2023
| let operatingSystem = Self.operatingSystem | ||
| let targetEnvironment = Self.targetEnvironment | ||
| let locale = Self.locale | ||
| var extensionIdentifier: String? = Self.extensionIdentifier |
There was a problem hiding this comment.
This one property was a var before, but I found no existing need to mutate it, the tests pass, and the property was previously internal, so I figured it was safe to change to let.
|
Fantastic! Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #115
DefaultSignalPayloadis in charge of computing the event's default payload likeappVersion,buildNumberetc., which some clients may want to send along to sources besides the TelemetryDeck SDK (for example, a backend service with its own analytics implementation). This PR gives the payload public access to enable that.