New force-sync method (load-capped) to track bad experiences that might lead users to leave/delete app (improved churn tracking) #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arity + update docs Some functions seem to be named after planned behavior that was never implemented. Therefore, the function names & docs were somewhat misleading. I adjusted the names to reflect what they actually do.
…urn optimization This new method should only be used in rare cases where an important information is sent to the servers that must reach the servers even if the user might leave the app right after and never return. This can be useful for apps that are used only once to track important last steps of the user. Or for experiences like errors that could make the user delete the app right after. Those error signals would never reach the server without this.
Jeehut
changed the title
|
I love this! |
winsmith
approved these changes
Feb 5, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Individual commits:
Some functions in
SignalManagerseemed to have been named after planned behavior that was never implemented.Therefore, the function names & docs were somewhat misleading. I adjusted the names to reflect what they actually do.
The new method
.requestImmediateSync()fixes #130 and should only be used in rare cases where important information is sent to the servers that must reach the servers even if the user might leave the app right after and never return. This can be useful for apps that are used only once to track important last steps of the user. Or for experiences like errors that could make the user delete the app right after. Those error signals would never reach the server without this.This PR also fixes #134 (a minor SwifUI logging issue).
It also fixes some warnings regarding
visionOS(instead ofxrOS) & improves Vison Pro support.