Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolved Tencent/TSW#317 #318

Merged
merged 1 commit into from
May 6, 2019
Merged

fix: resolved Tencent/TSW#317 #318

merged 1 commit into from
May 6, 2019

Conversation

zkd8907
Copy link
Collaborator

@zkd8907 zkd8907 commented Apr 27, 2019

Checklist:

用判断启动参数是否包含inspect来判断当前是否处于调试模式,以兼容Node 12移除process.binding('config').debugOptions后无法判断这一模式的问题。

@tencent-adm
Copy link
Member

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


lemanzhang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@zkd8907 zkd8907 requested a review from RobinzZH April 27, 2019 07:35
@codecov
Copy link

codecov bot commented Apr 27, 2019

Codecov Report

Merging #318 into dev will not change coverage.
The diff coverage is 75%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #318   +/-   ##
=======================================
  Coverage   42.17%   42.17%           
=======================================
  Files          49       49           
  Lines        2857     2857           
=======================================
  Hits         1205     1205           
  Misses       1652     1652
Impacted Files Coverage Δ
bin/tsw/util/logger/logger.config.js 52.94% <100%> (ø) ⬆️
bin/tsw/util/logger/logger.js 25.7% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f581373...e555f55. Read the comment docs.

Copy link
Collaborator

@RobinzZH RobinzZH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review ok

@zkd8907 zkd8907 merged commit 4c73d3a into Tencent:dev May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants