feat: 优化分库分表迁移过程中，task_instance_id 动态查询条件构造逻辑 #3324 #3327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
wangyu096
commented
Dec 12, 2024
wangyu096
commented
- 修复 AppResourceScopeInterceptor 未处理内部请求的问题; 改造之后，对于 /service 开头的内部请求，同样也会解析 AppResourceScope 到上下文中 (AppResourceScopeInterceptor.java)
- 修复使用线程池导致 JobExecuteContext 上下文丢失的问题（ContextExecutorService.java)
- 修复 API Path 不规范的问题（/service/stepInstance/appIds/{appId}/stepInstanceIds/{stepInstanceId}）
- 修复微服务重启之后，JobExecuteContext 上下文丢失的问题 ( ResultHandlerManage.StopTask.java)
- 优化 task_instance_id dao 查询条件构造逻辑。原先的逻辑，如果 JobExecuteContext 或者 JobExecuteContext.getAppResourceScope 不存在，会直接使用 DSL.trueCondition(),忽略了 taskInstanceId条件。但是在这个场景下逻辑是错误的，因为上下文信息并非是必须的，有些场景下并没上下文，所以这时候需要判断 job.features.daoAddTaskInstanceId.enabled 即可(TaskInstanceIdDynamicCondition.java)。直接使用 DSL.trueCondition 会导致一直忽略 taskInstanceId 查询条件
- 优化日志，便于后续观察和定位问题
jsonwan
reviewed
Dec 12, 2024
| @@ -41,7 +41,7 @@ | |||
| @SmartFeignClient(value = "job-execute", contextId = "stepInstanceResource") | |||
| @InternalAPI | |||
| public interface ServiceStepInstanceResource { | |||
| @GetMapping("/service/stepInstance/appIds/{appId}/stepInstanceIds/{stepInstanceId}") | |||
| @GetMapping("/service/stepInstance/app/{appId}/stepInstanceId/{stepInstanceId}") | |||
| InternalResponse<ServiceStepInstanceDTO> getStepInstance( | |||
There was a problem hiding this comment.
这个接口是不是也需要增加taskInstanceId参数，用于命中分库分表逻辑
|
WebSearchToolsResource中的两个接口未命中分库分表逻辑，需要确认下走全分片查询是否可行 |
已沟通，后续上线之后观察。理论上即使走全分片查询也能很快完成，因为在每个分片上都能命中索引 |
jsonwan
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.