Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logging/exception): remove redundant logging while handle the exceptions #290

Merged
merged 1 commit into from
Feb 24, 2022
Merged

fix(logging/exception): remove redundant logging while handle the exceptions #290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/api/bkuser_core/common/exception_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def get_ee_exception_response(exc, context):
elif isinstance(exc, AuthenticationFailed):
data["message"] = "403, authentication failed"
else:
logger.exception("request apiServer failed")
logger.exception("unknown exception while handling the request")
data["message"] = UNKNOWN_ERROR_HINT
data["code"] = -1

Expand All @@ -79,7 +79,6 @@ def get_ee_exception_response(exc, context):
setattr(response, "from_exception", True)
return response

logger.exception("request apiServer failed")
response = Response(data=data, status=EE_GENERAL_STATUS_CODE)
setattr(response, "from_exception", True)
return response
Expand Down