feat: record service instance which is unbound and recycle later #1775
+610
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -165,8 +172,21 @@ def provision(self): | |||
| ).inc() | |||
|
|
|||
| def recycle_resource(self): | |||
| if self.db_obj.service.prefer_async_delete: | |||
| self.mark_unbound() | |||
There was a problem hiding this comment.
解绑过程需要加逻辑 而不是在回收逻辑里面
你需要先在开发者中心试一下解绑服务是由那个接口或者入口触发的
There was a problem hiding this comment.
由这个接口触发，
DELETE make_app_pattern(f"/services/{SERVICE_UUID}/$", include_envs=False),
，会触发 ModuleCleaner.delete_services()，传入 service_id。 删除module时也会解绑增强服务，也会触发ModuleCleaner.delete_services()，不传service_id。
There was a problem hiding this comment.
远程增强服务也需要有 self.db_obj.service.prefer_async_delete 类似的判断逻辑
apiserver/paasng/paasng/accessories/servicehub/local/manager.py
Outdated
Show resolved
Hide resolved
| @@ -279,6 +285,7 @@ def sync_instance_config(self): | |||
| def recycle_resource(self): | |||
| """对于 remote service 我们默认其已经具备了回收的能力""" | |||
| if self.is_provisioned(): | |||
| self.mark_unbound() | |||
| ) | ||
| unbound_instance.recycle_instance() | ||
|
|
||
| return Response() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.