Skip to content

Commit

Permalink
Add copy sematic to userInfo in ASTextRunDelegate for avoiding …
Browse files Browse the repository at this point in the history 
…mutation (#1719)
  • Loading branch information
@hanton @vovasty
hanton authored and vovasty committed Nov 12, 2019
1 parent be96501 commit 37e2830
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Source/Private/TextExperiment/String/ASTextRunDelegate.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ NS_ASSUME_NONNULL_BEGIN
/**
Additional information about the the run delegate.
*/
@property (nullable, nonatomic) NSDictionary *userInfo;
@property (nullable, nonatomic, copy) NSDictionary *userInfo;

/**
The typographic ascent of glyphs in the run.
Expand Down

6 comments on commit 37e2830

@HariMohan-eng
Copy link

@HariMohan-eng HariMohan-eng commented on 37e2830 Nov 13, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi hebertialmeida,

I am unable to comment your "FolioReaderKit" library.

i am using pod 'FolioReaderKit', git: 'https://github.com/FolioReader/FolioReaderKit.git'. you can try on ios 13.1.2 or ios 13.2.2. (it works fine in ios 13 or below.) .

please see my video link.
https://drive.google.com/open?id=1RiZ-aXhr2m9QeGW4Ibao2Mu2Jn2d8ety

my epub book url is:- "http://testdemo.website/easydigy/wp-content/uploads/anthologize-temp/f9251fa2269326daefb8a263e818e1f09e8b5de1/book.epub"

please test my book url with your library , please fix my issue.

@HariMohan-eng
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have mailed you on "hebertialmeida@gmail.com", please connect with me, I am waiting your reply.

@HariMohan-eng
Copy link

@HariMohan-eng HariMohan-eng commented on 37e2830 Nov 14, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
I have solved my issue by writing code in your library mentioned below:-
Changes in Folio Reader Library

In FolioReaderWebView.swift
add:- self.scalesPageToFit = true
self.contentMode = .scaleAspectFit

In Style.css -------------------------------------------- 244-248 commented,
add:- html.textSizeOne, .textSizeOne body { font-size: 22px !important; }
html.textSizeTwo, .textSizeTwo body { font-size: 28px !important; }
html.textSizeThree, .textSizeThree body { font-size: 34px !important; }
html.textSizeFour, .textSizeFour body { font-size: 40px !important; }
html.textSizeFive, .textSizeFive body { font-size: 46px !important; }

NOTE:- now i have one issue, when sound playing highlight text is not working in iOS 13.1.2 & 13.2.2 because you are using UIWebView. I request your please use WKWebView because UIWebView has been deprecated, Please solve highlight text issue. please reply.

@HariMohan-eng
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider my comment.

@HariMohan-eng
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Herbertialmeida,
we are facing more errors with your "folio reader kit" library. Also apple has been deprecated UIWebView. In Future we can not use your library. please do it ASAP.

@HariMohan-eng
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are unable to comment on your folioreaderkit library, please fix this issue ASAP.

Please sign in to comment.