Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASImageNode]Incorrect calculation for backing size calculation #1052

Closed
junjielu opened this issue Jul 26, 2018 · 3 comments · Fixed by #1189
Closed

[ASImageNode]Incorrect calculation for backing size calculation #1052

junjielu opened this issue Jul 26, 2018 · 3 comments · Fixed by #1189

Comments

@junjielu
Copy link
Contributor

junjielu commented Jul 26, 2018

In demo project and screenshot, I create 2 simple ASImageNode with UIViewContentModeScaleAspectFit.
However, change the height of node will make image "blurred".

I also find that #836 has mentioned this issue too.I read the code about ASCroppedImageBackingSizeAndDrawRectInBounds, and I think there is something wrong with image draw rect calculation.

Sample Project

preview
@nguyenhuy @appleguy

@junjielu
Copy link
Contributor Author

Somebody help?

@TheRealVictor
Copy link

You might be able to use this answer 😄: #836 (comment)

@junjielu
Copy link
Contributor Author

You might be able to use this answer 😄: #836 (comment)

Thanks~
Yep, but I don't want to make image upscale, it may affect performance.
I think it's a bug of image draw rect calculation.

@junjielu junjielu changed the title ASImageNode Bug: UIViewContentModeScaleAspectFit will affect image's clarity [ASImageNode]Incorrect calculation for backing size calculation Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants