Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change layoutSizeDifferentFromBounds macro to a BOOL #1718

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Change layoutSizeDifferentFromBounds macro to a BOOL #1718

merged 1 commit into from
Nov 11, 2019

Conversation

hanton
Copy link
Contributor

@hanton hanton commented Oct 28, 2019

Rather than defining layoutSizeDifferentFromBounds as a macro, a BOOL can do the job.

@ernestmama
Copy link
Contributor

It looks good to me but I am not sure if there is any particular reason to do it that way in the beginning. Would love some eyes from others.

vovasty
vovasty approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@vovasty vovasty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Macro looks ugly. imho much simpler just remove the macro and add a comment about this check.

@ernestmama ernestmama merged commit 5f43300 into TextureGroup:master Nov 11, 2019
@hanton hanton deleted the change-layoutSizeDifferentFromBounds-macro-to-BOOL branch November 11, 2019 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernestmama ernestmama ernestmama approved these changes

@vovasty vovasty vovasty approved these changes

@maicki maicki Awaiting requested review from maicki

@nguyenhuy nguyenhuy Awaiting requested review from nguyenhuy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanton @ernestmama @vovasty