Docs: Fix references of ASViewController/ASNavigationController (non-existent) to ASDKViewController/ASDKNavigationController #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
JoeFerrucci
changed the title
VAndrJ
reviewed
Jan 23, 2023
| Benefits of using an `ASDKViewController`: | ||
| <ol> | ||
| <li><b>Save Memory</b>. An <code>ASDKViewController</code> that goes off screen will automatically reduce the size of the <a href="intelligent-preloading.html">fetch data</a> and <a href="intelligent-preloading.html">display ranges</a> of any of its children. This is key for memory management in large applications. </li> | ||
| <li><b><a href="asvisibility.html"><code>ASVisibility</code></a> Feature</b>. When used in an <code>ASNavigationController</code> or <code>ASTabBarController</code>, these classes know the exact number of user taps it would take to make the view controller visible.</li> |
There was a problem hiding this comment.
ASDKNavigationController, not ASNavigationController
There was a problem hiding this comment.
This was just for ASDKViewController but I can update it to change ASDKNavigationController as well. Thanks.
JoeFerrucci
changed the title
|
Updated PR to additionally change ASNavigationController to ASDKNavigationController. |
VAndrJ
approved these changes
Jan 23, 2023
|
Does this need anything else, or can we get this approved and merge this? |
|
Can we get this merged? It's been approved for almost 2 months. |
|
Who maintains this repo? |
garrettmoon
approved these changes
Apr 5, 2023
andrey-golovin-ios
added a commit
to andrey-golovin-ios/Texture
that referenced
this pull request
Oct 5, 2023
* 'master' of https://github.com/TextureGroup/Texture: Fix build errors and a crash in xcode 15 (TextureGroup#2093) [ASCellNodeVisibilityEvent] Add a new event when scrolling stops (TextureGroup#2084) Trying to get CI to work (TextureGroup#2085) fix typo: ASStackLayoutElement.h (TextureGroup#2067) Docs: Fix references of ASViewController/ASNavigationController (non-existent) to ASDKViewController/ASDKNavigationController (TextureGroup#2072) [ASTextKitRenderer] Adding locking when accessing the text renderer cache (TextureGroup#2075) Switch UITextWritingDirection to NSWritingDirection (TextureGroup#2071)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes documentation references of ASViewController and ASNavigationController (non-existent) to ASDKViewController and ASDKNavigationController.
As far as I can tell there's no such thing as ASViewController, and CHANGELOG says it was renamed in 3.0.0 (2020-07-15)
Same for ASNavigationController, Change was made in this CHANGELOG for 3.1.0