[ASTextKitRenderer] Adding locking when accessing the text renderer cache #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ache While NSCache is thread safe, that alone does not make `rendererForAttributes` thread safe. This experiment will add a lock to `rendererForAttributes` to see how that affects performance/stability. As second experiment will forego the cache altogether to validate that we are getting some value out of having a renderer cache.
garrettmoon
approved these changes
Jan 24, 2023
| @@ -130,6 +130,23 @@ - (BOOL)isEqual:(ASTextNodeRendererKey *)object | |||
| return renderer; | |||
| } | |||
|
|
|||
| static AS::RecursiveMutex __sharedRendererCacheInstanceLock__; | |||
There was a problem hiding this comment.
nit: should this go at the top with the other locks? Or is the thinking to clean this up if it works?
There was a problem hiding this comment.
Which other locks? Since these are static C functions I put the lock right next to them. Is there a better place to put them?
There was a problem hiding this comment.
Ignore me, I was looking at a different file 😅
andrey-golovin-ios
added a commit
to andrey-golovin-ios/Texture
that referenced
this pull request
Oct 5, 2023
* 'master' of https://github.com/TextureGroup/Texture: Fix build errors and a crash in xcode 15 (TextureGroup#2093) [ASCellNodeVisibilityEvent] Add a new event when scrolling stops (TextureGroup#2084) Trying to get CI to work (TextureGroup#2085) fix typo: ASStackLayoutElement.h (TextureGroup#2067) Docs: Fix references of ASViewController/ASNavigationController (non-existent) to ASDKViewController/ASDKNavigationController (TextureGroup#2072) [ASTextKitRenderer] Adding locking when accessing the text renderer cache (TextureGroup#2075) Switch UITextWritingDirection to NSWritingDirection (TextureGroup#2071)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While NSCache is thread safe, that alone does not make
rendererForAttributesthread safe. This experiment will add a lock torendererForAttributesto see how that affects performance/stability. As second experiment will forego the cache altogether to validate that we are getting some value out of having a renderer cache.