Add support for toggling logs off and back on at runtime #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenhuy
approved these changes
Dec 19, 2017
Generated by 🚫 Danger |
|
Just landed the PR. Thank you, @johntmcintosh! |
|
Great -- thanks @nguyenhuy! |
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #528 (and related issue #524) provided a mechanism to disable logs at runtime. In most of my apps, I like to expose a menu in debug builds which allows me to toggle logs of certain types on/off at runtime.
This PR adds an
ASEnableLogging()function which parallels the existingASDisableLogging(), so that logs can be toggled, rather than only disabled.