Added Missing MBP Eggs #129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DC levels didn't have any extra eggs
thearst3rd
requested changes
Jan 4, 2024
There was a problem hiding this comment.
There are many considerations here.
- I checked out this branch and the new eggs appear as they should (at least the few ones in beginner that I checked). However: On the play level gui, the egg graphic did not appear on the new levels until I manually deleted all of the
.mis.cachefiles and let them get regenerated. I don't know if PQ currently has a mechanism to discard existing cache files, so the new egg icons might not appear for existing players. - Some eggs require extra items/etc to be collected the intended way. For example, Magnet Training has many extra magnets which I believe are there to collect the easter egg, but in this pull request they are missing:
MBP 1.14
This PR
This leads me to believe that generally there are other levels that have been changed when the egg was removed to remove now-unnecessary powerups/oob-trigger space/etc. As part of this PR, we should make sure all new eggs are actually collectable and bring back anything that was needed to collect them.
- This will affect the speedrun leaderboard since there are new egg times. This may require extra work on the leaderboard server to ensure that speedrun times for the new eggs will be properly recorded.
- Related to above, this will have greater affects such as adding new eggs to the egg world record rampage. I think we should check with the moderators or maybe the community (maybe a vote?) to see if players actually want these eggs back. We probably shouldn't spend extra effort on the above tasks until we get the green light
- If we don't get the green light, we still may be able to consider adding these eggs in as offline-only collectibles, which I think in this PR they currently are (they're not added to the lbmissions)
- Blasted started writing easter egg hints for MBP, I don't remember if he finished them. If he did, then we should write in easter egg hints for these eggs as well so there aren't any awkward gaps.
Anyways there's tons to consider before we merge and at least one level should be changed but probably more.
commit 0d004d5 Merge: 4e8d1ef 3e1fffd Author: RandomityGuy <31925790+RandomityGuy@users.noreply.github.com> Date: Thu Jan 4 22:00:14 2024 +0530 Merge branch 'dev' of https://github.com/The-New-Platinum-Team/PlatinumQuest-Dev into dev commit 4e8d1ef Author: RandomityGuy <31925790+RandomityGuy@users.noreply.github.com> Date: Thu Jan 4 21:59:47 2024 +0530 add ability to launch marbleland levels from commandline args and rpc socket commit 3e1fffd Author: AGame-1 <130401553+AGame-1@users.noreply.github.com> Date: Thu Sep 28 17:04:37 2023 -0400 Allow changeEnvironment() to change the Sky without changing the Sun commit 08c4a87 Author: AGame-1 <130401553+AGame-1@users.noreply.github.com> Date: Thu Sep 28 15:29:58 2023 -0400 Update triggers.cs - Fixed Acceleration trigger being broken in Multiplayer - Environment trigger now works with checkpoints
-Super Jump and Gyrocopter on Keep On Rollin' -Gyrocopter on Learn the Bouncy Floor -Several magnets on Magnet Training -Several tornadoes on Tornado Launch -Gyrocopter on Ramp Madness -Gyrocopter on Wall Master -Super Jump on Winding Steps
EE hints
-Magnet Training has extra visible magnets -MAC and Winding Steps have visible Easter Eggs -Ramp Madness has an extra visible Gyrocopter
*Gravity Knot (Beginner) was missing an Easter Egg *Ring Stunts had an Out of Bounds Trigger in front of the Easter Egg
Turns out hahasuck is an extra OOB trigger, not the inbounds for the whole level
huh, idk how I didn't notice that Gravity Knot was missing too Also I did see hahasuck but I thought that was just the main OOB trigger
|
Superseded by #138 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DC levels didn't have any extra eggs