From 05b38df10d1f2b8a9a477b8059710b7634a0bcde Mon Sep 17 00:00:00 2001 From: MaximSmolskiy Date: Tue, 2 Apr 2024 19:39:51 +0300 Subject: [PATCH 1/2] Enable ruff S105 rule --- pyproject.toml | 1 - web_programming/recaptcha_verification.py | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index e3cf42c92c54..65a0754d678c 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -15,7 +15,6 @@ lint.ignore = [ # `ruff rule S101` for a description of that rule "PT018", # Assertion should be broken down into multiple parts "RUF00", # Ambiguous unicode character and other rules "S101", # Use of `assert` detected -- DO NOT FIX - "S105", # Possible hardcoded password: 'password' "S113", # Probable use of requests call without timeout -- FIX ME "S311", # Standard pseudo-random generators are not suitable for cryptographic purposes -- FIX ME "SLF001", # Private member accessed: `_Iterator` -- FIX ME diff --git a/web_programming/recaptcha_verification.py b/web_programming/recaptcha_verification.py index b03afb28ec53..4016a4071c3f 100644 --- a/web_programming/recaptcha_verification.py +++ b/web_programming/recaptcha_verification.py @@ -42,8 +42,8 @@ def login_using_recaptcha(request): - # Enter your recaptcha secret key here - secret_key = "secretKey" + # Enter your recaptcha secret key here, e.g. "secretKey" + secret_key = "" url = "https://www.google.com/recaptcha/api/siteverify" # when method is not POST, direct user to login page From 61dc7fc96ff74583bff1ec84074dc76c7ee1c80f Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Tue, 2 Apr 2024 18:44:10 +0200 Subject: [PATCH 2/2] Update web_programming/recaptcha_verification.py --- web_programming/recaptcha_verification.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/web_programming/recaptcha_verification.py b/web_programming/recaptcha_verification.py index 4016a4071c3f..c9b691b28a8b 100644 --- a/web_programming/recaptcha_verification.py +++ b/web_programming/recaptcha_verification.py @@ -42,8 +42,8 @@ def login_using_recaptcha(request): - # Enter your recaptcha secret key here, e.g. "secretKey" - secret_key = "" + # Enter your recaptcha secret key here + secret_key = "secretKey" # noqa: S105 url = "https://www.google.com/recaptcha/api/siteverify" # when method is not POST, direct user to login page