Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Typescript Tests #3744

Merged
merged 2 commits into from
Feb 3, 2024
Merged

Conversation

rzuckerm
Copy link
Collaborator

@rzuckerm rzuckerm commented Jan 27, 2024

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.

Please fill one of the sections below as applicable.
Please also add any other relevant information to the Notes section at the bottom.
You may delete or just ignore any other sections.
For more information please refer to our contributing documentation

I Am Modifying an Existing Code Snippet or Existing Tests

  • I fixed Modify Typescript Testing #3743
  • I have read about modifying existing code snippets or tests in the contributing documentation
  • I have explained why this modification is necessary either in the issue linked above or in the notes below
  • I named the pull request using Modify {PROJECT} {tests} in {LANGUAGE} format

Other Notes

I decided to use my own docker image. That way, I can expressly control what version of typescript and the @types/node package I use without having to worry about things changing in an undesirable way. Also, I'm now able to invoke the typescript compiler (tsc) directly and point it at the globally installed @types/node npm package.

@rzuckerm rzuckerm added bug Something isn't working tests Testing related labels Jan 27, 2024
@rzuckerm rzuckerm marked this pull request as ready for review January 27, 2024 20:25
@rzuckerm rzuckerm mentioned this pull request Jan 27, 2024
2 tasks
@jrg94 jrg94 self-assigned this Feb 3, 2024
@jrg94 jrg94 requested a review from a team February 3, 2024 01:12
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the change! Seems like a good approach. Are all your images tracked in GitHub somewhere?

@jrg94 jrg94 merged commit 8cb9362 into TheRenegadeCoder:main Feb 3, 2024
6 checks passed
@rzuckerm
Copy link
Collaborator Author

rzuckerm commented Feb 3, 2024

Yes, they are all in https://github.com/rzuckerm/<language-name>-docker-image. For example, here is the typescript image. I have a cookiecutter template that I use to generate them here.

@rzuckerm rzuckerm deleted the modify-typescript-test branch February 3, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests Testing related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify Typescript Testing
2 participants