Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Flashbangs Cannot Target Stinger Sites #297

Merged
merged 7 commits into from
Jul 16, 2023
Merged

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Sep 11, 2021

ZH 1.04

  • Due to a bug, Rangers while equipped with Flashbangs cannot be ordered to attack Stinger Sites.
  • Rangers will still target nearby Stinger Troopers in range when idle.
  • The player must click force fire next to the Stinger Site to target them manually. The cursor will show a forbidden sign while hovering over the Stinger Site.

After patch:

  • The attacker can just click on the Stinger Site with Flashbang Rangers and damage the Stinger Troopers normally.

@commy2 commy2 added the Bug Something is not working right label Sep 11, 2021
@commy2 commy2 changed the title Fix: Stinger Site Automatically Engages Buildings Fix: Flashbangs Cannot Target Stinger Sites Sep 11, 2021
@xezon xezon self-requested a review September 11, 2021 13:38
@xezon
Copy link
Collaborator

xezon commented Sep 11, 2021

Thinking about this now, I think this needs to be carefully evaluated. I am not convinced this is a bug, because China bunkers can also not be flash banged, right? Looks more like Design question. It would certainly be a little buff for USA when Stinger soldiers can be targeted by Flashbang men. This would allow a Ranger inside a Humvee for example to target a Stinger comfortably which would not be possible before.

@commy2
Copy link
Collaborator Author

commy2 commented Sep 11, 2021

What's weird is that they can already be hurt by Flashbangs. You just have to force-fire the ground next to the Site.

The Flashbangs damage type (SURRENDER) is also already set up to forward to the Trooper boys:

https://github.com/xezon/GeneralsGamePatch/blob/main/Patch104pZH/GameFilesOriginal/Data/INI/Object/ChemicalGeneral.ini#L5050

We could alternatively make the Troopers immune to Flashbangs completely. The current state is very strange though.

@MTKing4
Copy link
Collaborator

MTKing4 commented Sep 11, 2021

i think making them immune is the wisest call, it's a base defense, it shouldn't be taken out by a main infantry unit

@commy2 commy2 added the OngoingDiscussion Requires further discussion label Sep 11, 2021
@RisingZH
Copy link

Interesting one, if it was fixed how many flashbang grenades would it take to clear the stinger?

@xezon
Copy link
Collaborator

xezon commented Sep 11, 2021

I tracked a related design question here for completeness sake: #302

@commy2
Copy link
Collaborator Author

commy2 commented Sep 11, 2021

how many flashbang grenades would it take to clear the stinger?

3

Edit: Sometimes 4. Depends on how the Flashbang scatters.

@Generalcamo Generalcamo linked an issue Sep 12, 2021 that may be closed by this pull request
@Madrageeeeee
Copy link

again, dont think this is a clear bug problem. Not sure if this requires patching / changing. Usa with humvees dont really have a problem with stinger sites anyway currently

@xezon
Copy link
Collaborator

xezon commented Jan 1, 2022

I think we should not buff USA with being able to kill Stinger Trooper with Flashbang. USA is good enough as is. Making the Stringer Troopers immune to flashbang should be ok however, because no one really force fires next to Stingers currently and USA does not need that ability to be strong.

@commy2 commy2 closed this in #636 Jan 3, 2022
@xezon xezon removed the OngoingDiscussion Requires further discussion label Aug 22, 2022
@xezon xezon deleted the fix-flashbangs-vs-stingers branch August 30, 2022 19:26
@commy2 commy2 restored the fix-flashbangs-vs-stingers branch July 16, 2023 14:12
@commy2 commy2 reopened this Jul 16, 2023
@commy2
Copy link
Collaborator Author

commy2 commented Jul 16, 2023

Usa with humvees dont really have a problem with stinger sites anyway currently

Flashbangs are able to target Stinger Sites while inside Humvees regardless of this fix.

I think we should not buff USA with being able to kill Stinger Trooper with Flashbang.

They already will target nearby Stinger Troopers if no other valid target is closer. This fix just enables the player to actually controll their units, which is better for gameplay.

i think making them immune is the wisest call, it's a base defense, it shouldn't be taken out by a main infantry unit

I see no reason to buff Stinger Sites and nerf Flashbangs. Making the player able to properly control their units does not make USA OP suddenly. This is an extremely niche control bug. Fixing it will not suddenly make Stinger Sites worse against USA.

@xezon

This comment was marked as resolved.

@commy2 commy2 closed this Jul 16, 2023
@commy2 commy2 force-pushed the fix-flashbangs-vs-stingers branch from ab0fc16 to 3861d48 Compare July 16, 2023 14:32
@commy2 commy2 reopened this Jul 16, 2023
@commy2 commy2 force-pushed the fix-flashbangs-vs-stingers branch from 4797161 to 663d0e0 Compare July 16, 2023 14:57
@commy2 commy2 force-pushed the fix-flashbangs-vs-stingers branch from 2b05cf1 to 4ed3f72 Compare July 16, 2023 15:29
@commy2

This comment was marked as resolved.

@commy2 commy2 force-pushed the fix-flashbangs-vs-stingers branch from f12e4b1 to e1a078b Compare July 16, 2023 15:34
@commy2

This comment was marked as resolved.

@xezon

This comment was marked as resolved.

@commy2

This comment was marked as resolved.

@xezon

This comment was marked as resolved.

@commy2

This comment was marked as resolved.

@commy2 commy2 merged commit f6e663b into main Jul 16, 2023
@commy2 commy2 deleted the fix-flashbangs-vs-stingers branch July 16, 2023 21:03
@ImTimK
Copy link
Collaborator

ImTimK commented Jul 17, 2023

Think it makes sense if flashbangs do clear stingers, although I don't believe dragons do?

@commy2
Copy link
Collaborator Author

commy2 commented Jul 17, 2023

Flashbangs don't clear Stinger Sites, they damage Stinger Soldiers. Same for Dragon tanks, they also don't clear Stinger Sites, but damage Stinger Soldiers via splash damage. The difference is only that you can click on Stinger Sites with Dragons, but not Flashbangs in 1.04. This is the fix for that. Rangers shoot and damage Stinger Troopers with or without this when idle.

@commy2 commy2 mentioned this pull request Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GLA Stinger can be attacked by USA Sniper but not by USA Flashbang
6 participants