Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give groups a visual border #1287

Open
tordans opened this issue Sep 1, 2024 · 2 comments
Open

Give groups a visual border #1287

tordans opened this issue Sep 1, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request roadmap Something we're planning to solve

Comments

@tordans
Copy link
Contributor

tordans commented Sep 1, 2024

I want to revisit the idea to add a visual indication for groups.

(…) It lacks the prominent delineation of your example, which I'd like to revisit in the future. From memory we were concerned about introducing too much chrome, considering that objects may be infinitely nested.

Originally posted by @jossmac in #641 (comment)

Current Proposal
current proposal

From memory we were concerned about introducing too much chrome, considering that objects may be infinitely nested.

I expect the primary use case to have one group. So IMO the UI should serve this use case first. However, if deeply nested structures are in deed something that happens a lot and the border does indeed make this case noticably worse, we could add custom CSS to only show the border on the first level. Or introduce a new flag like showGrouped: true to opt into the border.

@jossmac jossmac self-assigned this Sep 5, 2024
@jossmac jossmac added enhancement New feature or request roadmap Something we're planning to solve labels Sep 5, 2024
@jossmac
Copy link
Member

jossmac commented Sep 5, 2024

Thanks for the reminder, @tordans! Keen to take another look at this in the near future

@tordans
Copy link
Contributor Author

tordans commented Sep 5, 2024

@jossmac happy to help once I get #1285 or "how to get this project running locally" sorted out…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request roadmap Something we're planning to solve
Projects
None yet
Development

No branches or pull requests

2 participants