Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to for inactive stack updates when instances are 0 #86

Merged
merged 2 commits into from Mar 30, 2017
Merged

Fix to for inactive stack updates when instances are 0 #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fda5300
Update eb_environment.rb
Oct 12, 2016
b2b20f0
Update aws_driver_stubs.rb
Oct 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/eb_deployer/eb_environment.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def deploy(version_label, settings={})
def apply_settings(settings)
raise "Env #{self.name} not exists for applying settings" unless @bs.environment_exists?(@app, @name)
wait_for_env_status_to_be_ready
with_polling_events(/Environment update completed successfully/i) do
with_polling_events(/Successfully deployed new configuration to environment/i) do
@bs.update_environment_settings(@app, @name, settings)
end
end
Expand Down Expand Up @@ -104,7 +104,7 @@ def create_eb_env(settings, version_label)
end

def update_eb_env(settings, version_label)
with_polling_events(/Environment update completed successfully/i) do
with_polling_events(/Successfully deployed new configuration to environment/i) do
@bs.update_environment(@app,
@name,
version_label,
Expand Down
2 changes: 1 addition & 1 deletion test/aws_driver_stubs.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def fetch_events(app_name, env_name, options={})
set_env_ready(app_name, env_name, true) # assume env become ready after it spit out all the events

unless @events # unrestricted mode for testing if no explicit events set
return [generate_event_from_messages(['Environment update completed successfully',
return [generate_event_from_messages(['Successfully deployed new configuration to environment',
'terminateEnvironment completed successfully',
'Successfully launched environment',
'Completed swapping CNAMEs for environments'
Expand Down