Handle subscription with topic from different project #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblaszczak
reviewed
Jun 26, 2021
pkg/googlecloud/subscriber.go
Outdated
| @@ -86,6 +90,15 @@ type SubscriberConfig struct { | |||
| Unmarshaler Unmarshaler | |||
| } | |||
|
|
|||
| // FetchTopicProjectID returns the proper topic project ID to use. | |||
| func (sc SubscriberConfig) FetchTopicProjectID() string { | |||
There was a problem hiding this comment.
Could you make this method private? I guess that we don't need to extend public API 😉.
I'm also thinking if just topicProjectID() will be not better because we are not fetching anything - it's just a getter :)
roblaszczak
reviewed
Jun 26, 2021
|
Hey @medinae! Thanks for your PR. I left 2 small comments. We can go forward after addressing them :) |
|
@roblaszczak done, please check again. thanks. |
|
@roblaszczak can we move forward with it man? |
|
Hey, yes! Sorry for the delay and thanks for your contribution 🎖️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves this issue, and solution is totally backward compatible.