Adds pubsub.ClientConfig to the configuration #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pubsub client has more configuration options that what was being exposed by the watermill configuration structs. This adds the missing pubsub.ClientConfig struct to the watermill configuration structs and changes the client initialization to NewClientWithConfig instead of NewClient.
|
Thank you @rjfonseca! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pubsub client has more configuration options that what was being exposed by the watermill configuration structs in the publisher and the subscriber.
This commit adds the missing pubsub.ClientConfig struct to the watermill configuration structs and changes the client initialization to NewClientWithConfig instead of NewClient.
This change is retro-compatible because it defaults to nil, which is the same default value used by the pubsub client.
This this is necessary to enable OpenTelemetry support in pubsub client by setting
EnableOpenTelemetryTracingin theClientConfigstruct.