Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tag-pill editor style assignment #8739

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pmario
Copy link
Member

@pmario pmario commented Nov 13, 2024

Copy link

Confirmed: pmario has already signed the Contributor License Agreement (see contributing.md)

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for tiddlywiki-previews ready!

Name Link
🔨 Latest commit 22a2bd2
🔍 Latest deploy log https://app.netlify.com/sites/tiddlywiki-previews/deploys/6734d9f2deade60008e225ca
😎 Deploy Preview https://deploy-preview-8739--tiddlywiki-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pmario
Copy link
Member Author

pmario commented Nov 13, 2024

The test tiddler code

  • needs to be saved
  • and edited, to see what's going on
title: my-tag
tags: my-tag $:/tags/Stylesheet
color: my-tag

span.tc-tag-label[style*='my-tag'] {
  border:1px solid #08c;
  background-color:white;
  color:#08f !important;
  font-size:1rem;
  font-weight:bold;
}

@pmario
Copy link
Member Author

pmario commented Nov 13, 2024

@Jermolene -- This is a fix for #8737 if it is considered a regression

@pmario
Copy link
Member Author

pmario commented Nov 16, 2024

@CodaCodr -- Can you please test this one. https://deploy-preview-8739--tiddlywiki-previews.netlify.app/

@CodaCodr
Copy link
Contributor

PASS

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Regression] Tag pill style became ineffective in edit mode after 5.3.3
2 participants