From 8dd9bd53f415d618265622f61cfdaa69662632ac Mon Sep 17 00:00:00 2001 From: Tim Oliver Date: Mon, 8 Jul 2019 00:16:41 +0900 Subject: [PATCH 1/4] Refactored cancel dialog for better UX --- .../TOCropViewController/TOCropViewController.m | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/Objective-C/TOCropViewController/TOCropViewController.m b/Objective-C/TOCropViewController/TOCropViewController.m index deec4db5..630b0df5 100755 --- a/Objective-C/TOCropViewController/TOCropViewController.m +++ b/Objective-C/TOCropViewController/TOCropViewController.m @@ -841,7 +841,7 @@ - (void)dismissAnimatedFromParentViewController:(UIViewController *)viewControll #pragma mark - Button Feedback - - (void)cancelButtonTapped { - if (!self.cropView.canBeReset || !self.showCancelConfirmationDialog) { + if (!self.showCancelConfirmationDialog) { [self dismissCropViewController]; return; } @@ -849,14 +849,13 @@ - (void)cancelButtonTapped // Get the resource bundle depending on the framework/dependency manager we're using NSBundle *resourceBundle = TO_CROP_VIEW_RESOURCE_BUNDLE_FOR_OBJECT(self); - NSString *title = NSLocalizedStringFromTableInBundle(@"Delete Changes?", @"TOCropViewControllerLocalizable", resourceBundle, nil); - UIAlertController *alertController = [UIAlertController alertControllerWithTitle:title + UIAlertController *alertController = [UIAlertController alertControllerWithTitle:nil message:nil preferredStyle:UIAlertControllerStyleActionSheet]; + alertController.popoverPresentationController.sourceView = self.toolbar.visibleCancelButton; - - NSString *yesButtonTitle = NSLocalizedStringFromTableInBundle(@"Yes", @"TOCropViewControllerLocalizable", resourceBundle, nil); - NSString *noButtonTitle = NSLocalizedStringFromTableInBundle(@"No", @"TOCropViewControllerLocalizable", resourceBundle, nil); + NSString *yesButtonTitle = NSLocalizedStringFromTableInBundle(@"Delete Changes", @"TOCropViewControllerLocalizable", resourceBundle, nil); + NSString *noButtonTitle = NSLocalizedStringFromTableInBundle(@"Cancel", @"TOCropViewControllerLocalizable", resourceBundle, nil); __weak typeof (self) weakSelf = self; UIAlertAction *yesAction = [UIAlertAction actionWithTitle:yesButtonTitle style:UIAlertActionStyleDestructive handler:^(UIAlertAction *action) { From 4fe9b48e98ffa7531fc3df6f374ee861458727b2 Mon Sep 17 00:00:00 2001 From: Tim Oliver Date: Mon, 8 Jul 2019 00:17:09 +0900 Subject: [PATCH 2/4] Added visible cancel button property to toolbar --- .../Views/TOCropToolbar.h | 21 ++++++++++--------- .../Views/TOCropToolbar.m | 9 ++++++++ 2 files changed, 20 insertions(+), 10 deletions(-) diff --git a/Objective-C/TOCropViewController/Views/TOCropToolbar.h b/Objective-C/TOCropViewController/Views/TOCropToolbar.h index 93f6d9fd..2b59453d 100644 --- a/Objective-C/TOCropViewController/Views/TOCropToolbar.h +++ b/Objective-C/TOCropViewController/Views/TOCropToolbar.h @@ -35,24 +35,25 @@ NS_ASSUME_NONNULL_BEGIN /* The 'Done' buttons to commit the crop. The text button is displayed in portrait mode and the icon one, in landscape. */ -@property (nonnull, nonatomic, strong, readonly) UIButton *doneTextButton; -@property (nonnull, nonatomic, strong, readonly) UIButton *doneIconButton; -@property (nonnull, nonatomic, copy) NSString *doneTextButtonTitle; +@property (nonatomic, strong, readonly) UIButton *doneTextButton; +@property (nonatomic, strong, readonly) UIButton *doneIconButton; +@property (nonatomic, copy) NSString *doneTextButtonTitle; /* The 'Cancel' buttons to cancel the crop. The text button is displayed in portrait mode and the icon one, in landscape. */ -@property (nonnull, nonatomic, strong, readonly) UIButton *cancelTextButton; -@property (nonnull, nonatomic, strong, readonly) UIButton *cancelIconButton; -@property (nonnull, nonatomic, copy) NSString *cancelTextButtonTitle; +@property (nonatomic, strong, readonly) UIButton *cancelTextButton; +@property (nonatomic, strong, readonly) UIButton *cancelIconButton; +@property (nonatomic, readonly) UIView *visibleCancelButton; +@property (nonatomic, copy) NSString *cancelTextButtonTitle; /* The cropper control buttons */ -@property (nonnull, nonatomic, strong, readonly) UIButton *rotateCounterclockwiseButton; -@property (nonnull, nonatomic, strong, readonly) UIButton *resetButton; -@property (nonnull, nonatomic, strong, readonly) UIButton *clampButton; +@property (nonatomic, strong, readonly) UIButton *rotateCounterclockwiseButton; +@property (nonatomic, strong, readonly) UIButton *resetButton; +@property (nonatomic, strong, readonly) UIButton *clampButton; @property (nullable, nonatomic, strong, readonly) UIButton *rotateClockwiseButton; -@property (nonnull, nonatomic, readonly) UIButton *rotateButton; // Points to `rotateCounterClockwiseButton` +@property (nonatomic, readonly) UIButton *rotateButton; // Points to `rotateCounterClockwiseButton` /* Button feedback handler blocks */ @property (nullable, nonatomic, copy) void (^cancelButtonTapped)(void); diff --git a/Objective-C/TOCropViewController/Views/TOCropToolbar.m b/Objective-C/TOCropViewController/Views/TOCropToolbar.m index 407d606b..b3f64b82 100644 --- a/Objective-C/TOCropViewController/Views/TOCropToolbar.m +++ b/Objective-C/TOCropViewController/Views/TOCropToolbar.m @@ -613,4 +613,13 @@ - (void)setStatusBarHeightInset:(CGFloat)statusBarHeightInset [self setNeedsLayout]; } +- (UIView *)visibleCancelButton +{ + if (self.cancelIconButton.hidden == NO) { + return self.cancelIconButton; + } + + return self.cancelTextButton; +} + @end From 83d43537daf96cac5a2c438c842c1ade9e03de56 Mon Sep 17 00:00:00 2001 From: Tim Oliver Date: Mon, 8 Jul 2019 00:18:15 +0900 Subject: [PATCH 3/4] Changed localization to remove question mark --- .../Base.lproj/TOCropViewControllerLocalizable.strings | 2 +- .../Resources/ar.lproj/TOCropViewControllerLocalizable.strings | 2 +- .../da-DK.lproj/TOCropViewControllerLocalizable.strings | 2 +- .../Resources/de.lproj/TOCropViewControllerLocalizable.strings | 2 +- .../Resources/en.lproj/TOCropViewControllerLocalizable.strings | 2 +- .../Resources/es.lproj/TOCropViewControllerLocalizable.strings | 2 +- .../fa-IR.lproj/TOCropViewControllerLocalizable.strings | 2 +- .../Resources/fa.lproj/TOCropViewControllerLocalizable.strings | 2 +- .../Resources/fi.lproj/TOCropViewControllerLocalizable.strings | 2 +- .../Resources/fr.lproj/TOCropViewControllerLocalizable.strings | 2 +- .../Resources/hu.lproj/TOCropViewControllerLocalizable.strings | 2 +- .../Resources/id.lproj/TOCropViewControllerLocalizable.strings | 2 +- .../Resources/it.lproj/TOCropViewControllerLocalizable.strings | 2 +- .../Resources/ja.lproj/TOCropViewControllerLocalizable.strings | 2 +- .../Resources/ko.lproj/TOCropViewControllerLocalizable.strings | 2 +- .../Resources/ms.lproj/TOCropViewControllerLocalizable.strings | 2 +- .../Resources/nl.lproj/TOCropViewControllerLocalizable.strings | 2 +- .../Resources/pl.lproj/TOCropViewControllerLocalizable.strings | 2 +- .../Resources/pt.lproj/TOCropViewControllerLocalizable.strings | 2 +- .../Resources/ro.lproj/TOCropViewControllerLocalizable.strings | 2 +- .../Resources/ru.lproj/TOCropViewControllerLocalizable.strings | 2 +- .../Resources/tr.lproj/TOCropViewControllerLocalizable.strings | 2 +- .../Resources/vi.lproj/TOCropViewControllerLocalizable.strings | 2 +- .../zh-Hans.lproj/TOCropViewControllerLocalizable.strings | 2 +- .../zh-Hant.lproj/TOCropViewControllerLocalizable.strings | 2 +- 25 files changed, 25 insertions(+), 25 deletions(-) diff --git a/Objective-C/TOCropViewController/Resources/Base.lproj/TOCropViewControllerLocalizable.strings b/Objective-C/TOCropViewController/Resources/Base.lproj/TOCropViewControllerLocalizable.strings index 145e2067..aca943ec 100644 --- a/Objective-C/TOCropViewController/Resources/Base.lproj/TOCropViewControllerLocalizable.strings +++ b/Objective-C/TOCropViewController/Resources/Base.lproj/TOCropViewControllerLocalizable.strings @@ -3,6 +3,6 @@ "Reset" = "Reset"; "Original" = "Original"; "Square" = "Square"; -"Delete Changes?" = "Delete Changes?"; +"Delete Changes" = "Delete Changes"; "Yes" = "Yes"; "No" = "No"; diff --git a/Objective-C/TOCropViewController/Resources/ar.lproj/TOCropViewControllerLocalizable.strings b/Objective-C/TOCropViewController/Resources/ar.lproj/TOCropViewControllerLocalizable.strings index 9bddb7ab..a6fe0778 100644 --- a/Objective-C/TOCropViewController/Resources/ar.lproj/TOCropViewControllerLocalizable.strings +++ b/Objective-C/TOCropViewController/Resources/ar.lproj/TOCropViewControllerLocalizable.strings @@ -3,7 +3,7 @@ "Reset" = "إعادة تعيين"; "Original" = "أصلي"; "Square" = "مربع"; -"Delete Changes?" = "حذف التغييرات؟"; +"Delete Changes" = "حذف التغييرات"; "Yes" = "نعم"; "No" = "لا"; diff --git a/Objective-C/TOCropViewController/Resources/da-DK.lproj/TOCropViewControllerLocalizable.strings b/Objective-C/TOCropViewController/Resources/da-DK.lproj/TOCropViewControllerLocalizable.strings index 20fd8e2c..ef9c884f 100644 --- a/Objective-C/TOCropViewController/Resources/da-DK.lproj/TOCropViewControllerLocalizable.strings +++ b/Objective-C/TOCropViewController/Resources/da-DK.lproj/TOCropViewControllerLocalizable.strings @@ -3,6 +3,6 @@ "Reset" = "Nulstil"; "Original" = "Original"; "Square" = "Firkantet"; -"Delete Changes?" = "Slet ændringer?"; +"Delete Changes" = "Slet ændringer"; "Yes" = "Ja"; "No" = "Nej"; diff --git a/Objective-C/TOCropViewController/Resources/de.lproj/TOCropViewControllerLocalizable.strings b/Objective-C/TOCropViewController/Resources/de.lproj/TOCropViewControllerLocalizable.strings index efea8632..edaca3f0 100644 --- a/Objective-C/TOCropViewController/Resources/de.lproj/TOCropViewControllerLocalizable.strings +++ b/Objective-C/TOCropViewController/Resources/de.lproj/TOCropViewControllerLocalizable.strings @@ -3,6 +3,6 @@ "Reset" = "Zurücksetzen"; "Original" = "Original"; "Square" = "Quadrat"; -"Delete Changes?" = "Änderungen löschen?"; +"Delete Changes" = "Änderungen löschen"; "Yes" = "Ja"; "No" = "Nein"; diff --git a/Objective-C/TOCropViewController/Resources/en.lproj/TOCropViewControllerLocalizable.strings b/Objective-C/TOCropViewController/Resources/en.lproj/TOCropViewControllerLocalizable.strings index 145e2067..aca943ec 100644 --- a/Objective-C/TOCropViewController/Resources/en.lproj/TOCropViewControllerLocalizable.strings +++ b/Objective-C/TOCropViewController/Resources/en.lproj/TOCropViewControllerLocalizable.strings @@ -3,6 +3,6 @@ "Reset" = "Reset"; "Original" = "Original"; "Square" = "Square"; -"Delete Changes?" = "Delete Changes?"; +"Delete Changes" = "Delete Changes"; "Yes" = "Yes"; "No" = "No"; diff --git a/Objective-C/TOCropViewController/Resources/es.lproj/TOCropViewControllerLocalizable.strings b/Objective-C/TOCropViewController/Resources/es.lproj/TOCropViewControllerLocalizable.strings index 16575dd8..fbf329ef 100644 --- a/Objective-C/TOCropViewController/Resources/es.lproj/TOCropViewControllerLocalizable.strings +++ b/Objective-C/TOCropViewController/Resources/es.lproj/TOCropViewControllerLocalizable.strings @@ -3,6 +3,6 @@ "Reset" = "Cambiar"; "Original" = "Original"; "Square" = "Cuadrada"; -"Delete Changes?" = "Eliminar cambios?"; +"Delete Changes" = "Eliminar cambios"; "Yes" = "Sí"; "No" = "No"; diff --git a/Objective-C/TOCropViewController/Resources/fa-IR.lproj/TOCropViewControllerLocalizable.strings b/Objective-C/TOCropViewController/Resources/fa-IR.lproj/TOCropViewControllerLocalizable.strings index 6caf5f49..0316966b 100644 --- a/Objective-C/TOCropViewController/Resources/fa-IR.lproj/TOCropViewControllerLocalizable.strings +++ b/Objective-C/TOCropViewController/Resources/fa-IR.lproj/TOCropViewControllerLocalizable.strings @@ -3,6 +3,6 @@ "Reset" = "بازنشانی"; "Original" = "اصلی"; "Square" = "مربع"; -"Delete Changes?" = "حذف تغییرات؟"; +"Delete Changes" = "حذف تغییرات"; "Yes" = "آری"; "No" = "نه"; diff --git a/Objective-C/TOCropViewController/Resources/fa.lproj/TOCropViewControllerLocalizable.strings b/Objective-C/TOCropViewController/Resources/fa.lproj/TOCropViewControllerLocalizable.strings index 6caf5f49..0316966b 100644 --- a/Objective-C/TOCropViewController/Resources/fa.lproj/TOCropViewControllerLocalizable.strings +++ b/Objective-C/TOCropViewController/Resources/fa.lproj/TOCropViewControllerLocalizable.strings @@ -3,6 +3,6 @@ "Reset" = "بازنشانی"; "Original" = "اصلی"; "Square" = "مربع"; -"Delete Changes?" = "حذف تغییرات؟"; +"Delete Changes" = "حذف تغییرات"; "Yes" = "آری"; "No" = "نه"; diff --git a/Objective-C/TOCropViewController/Resources/fi.lproj/TOCropViewControllerLocalizable.strings b/Objective-C/TOCropViewController/Resources/fi.lproj/TOCropViewControllerLocalizable.strings index 719cd2f8..fdb3422f 100644 --- a/Objective-C/TOCropViewController/Resources/fi.lproj/TOCropViewControllerLocalizable.strings +++ b/Objective-C/TOCropViewController/Resources/fi.lproj/TOCropViewControllerLocalizable.strings @@ -3,6 +3,6 @@ "Reset" = "Palauta"; "Original" = "Alkuperäinen"; "Square" = "Neliö"; -"Delete Changes?" = "Peru muutokset?"; +"Delete Changes" = "Peru muutokset"; "Yes" = "Kyllä"; "No" = "Ei"; diff --git a/Objective-C/TOCropViewController/Resources/fr.lproj/TOCropViewControllerLocalizable.strings b/Objective-C/TOCropViewController/Resources/fr.lproj/TOCropViewControllerLocalizable.strings index 182d5620..fb1bc694 100644 --- a/Objective-C/TOCropViewController/Resources/fr.lproj/TOCropViewControllerLocalizable.strings +++ b/Objective-C/TOCropViewController/Resources/fr.lproj/TOCropViewControllerLocalizable.strings @@ -3,6 +3,6 @@ "Reset" = "Réinitialiser"; "Original" = "D’origine"; "Square" = "Carré"; -"Delete Changes?" = "Supprimer les modifications?"; +"Delete Changes" = "Supprimer les modifications"; "Yes" = "Oui"; "No" = "Non"; diff --git a/Objective-C/TOCropViewController/Resources/hu.lproj/TOCropViewControllerLocalizable.strings b/Objective-C/TOCropViewController/Resources/hu.lproj/TOCropViewControllerLocalizable.strings index 30737d00..0fff7eec 100644 --- a/Objective-C/TOCropViewController/Resources/hu.lproj/TOCropViewControllerLocalizable.strings +++ b/Objective-C/TOCropViewController/Resources/hu.lproj/TOCropViewControllerLocalizable.strings @@ -3,7 +3,7 @@ "Reset" = "Visszaállítás"; "Original" = "Eredeti"; "Square" = "Négyzet"; -"Delete Changes?" = "Módosítások törlése?"; +"Delete Changes" = "Módosítások törlése"; "Yes" = "Igen"; "No" = "Nem"; diff --git a/Objective-C/TOCropViewController/Resources/id.lproj/TOCropViewControllerLocalizable.strings b/Objective-C/TOCropViewController/Resources/id.lproj/TOCropViewControllerLocalizable.strings index 730016c6..b490df3d 100644 --- a/Objective-C/TOCropViewController/Resources/id.lproj/TOCropViewControllerLocalizable.strings +++ b/Objective-C/TOCropViewController/Resources/id.lproj/TOCropViewControllerLocalizable.strings @@ -3,6 +3,6 @@ "Reset" = "Atur Ulang"; "Original" = "Asli"; "Square" = "Persegi"; -"Delete Changes?" = "Hapus Perubahan?"; +"Delete Changes" = "Hapus Perubahan"; "Yes" = "Ya"; "No" = "Tidak"; diff --git a/Objective-C/TOCropViewController/Resources/it.lproj/TOCropViewControllerLocalizable.strings b/Objective-C/TOCropViewController/Resources/it.lproj/TOCropViewControllerLocalizable.strings index 689a274b..578aed7c 100644 --- a/Objective-C/TOCropViewController/Resources/it.lproj/TOCropViewControllerLocalizable.strings +++ b/Objective-C/TOCropViewController/Resources/it.lproj/TOCropViewControllerLocalizable.strings @@ -3,6 +3,6 @@ "Reset" = "Ripristina"; "Original" = "Originale"; "Square" = "Quadrato"; -"Delete Changes?" = "Elimina modifiche?"; +"Delete Changes" = "Elimina modifiche"; "Yes" = "Sì"; "No" = "No"; diff --git a/Objective-C/TOCropViewController/Resources/ja.lproj/TOCropViewControllerLocalizable.strings b/Objective-C/TOCropViewController/Resources/ja.lproj/TOCropViewControllerLocalizable.strings index 7560b9f2..35e0be70 100644 --- a/Objective-C/TOCropViewController/Resources/ja.lproj/TOCropViewControllerLocalizable.strings +++ b/Objective-C/TOCropViewController/Resources/ja.lproj/TOCropViewControllerLocalizable.strings @@ -3,6 +3,6 @@ "Reset" = "リセット"; "Original" = "オリジナル"; "Square" = "スクエア"; -"Delete Changes?" = "変更を削除?"; +"Delete Changes" = "変更を削除"; "Yes" = "はい"; "No" = "いいえ"; diff --git a/Objective-C/TOCropViewController/Resources/ko.lproj/TOCropViewControllerLocalizable.strings b/Objective-C/TOCropViewController/Resources/ko.lproj/TOCropViewControllerLocalizable.strings index 63cdf565..6d6bd4b3 100644 --- a/Objective-C/TOCropViewController/Resources/ko.lproj/TOCropViewControllerLocalizable.strings +++ b/Objective-C/TOCropViewController/Resources/ko.lproj/TOCropViewControllerLocalizable.strings @@ -3,6 +3,6 @@ "Reset" = "재설정"; "Original" = "원본"; "Square" = "정방형"; -"Delete Changes?" = "변경사항 삭제"; +"Delete Changes" = "변경사항 삭제"; "Yes" = "예"; "No" = "아니요"; diff --git a/Objective-C/TOCropViewController/Resources/ms.lproj/TOCropViewControllerLocalizable.strings b/Objective-C/TOCropViewController/Resources/ms.lproj/TOCropViewControllerLocalizable.strings index 988e1515..2a719859 100644 --- a/Objective-C/TOCropViewController/Resources/ms.lproj/TOCropViewControllerLocalizable.strings +++ b/Objective-C/TOCropViewController/Resources/ms.lproj/TOCropViewControllerLocalizable.strings @@ -3,6 +3,6 @@ "Reset" = "Reset"; "Original" = "Asal"; "Square" = "Segi empat"; -"Delete Changes?" = "Padam Perubahan?"; +"Delete Changes" = "Padam Perubahan"; "Yes" = "Ya"; "No" = "Tidak"; diff --git a/Objective-C/TOCropViewController/Resources/nl.lproj/TOCropViewControllerLocalizable.strings b/Objective-C/TOCropViewController/Resources/nl.lproj/TOCropViewControllerLocalizable.strings index a795e94a..0dacf096 100644 --- a/Objective-C/TOCropViewController/Resources/nl.lproj/TOCropViewControllerLocalizable.strings +++ b/Objective-C/TOCropViewController/Resources/nl.lproj/TOCropViewControllerLocalizable.strings @@ -3,6 +3,6 @@ "Reset" = "Herstel"; "Original" = "Origineel"; "Square" = "Vierkant"; -"Delete Changes?" = "Wis wijzigingen?"; +"Delete Changes" = "Wis wijzigingen"; "Yes" = "Ja"; "No" = "Nee"; diff --git a/Objective-C/TOCropViewController/Resources/pl.lproj/TOCropViewControllerLocalizable.strings b/Objective-C/TOCropViewController/Resources/pl.lproj/TOCropViewControllerLocalizable.strings index 41625938..a0f07c4a 100644 --- a/Objective-C/TOCropViewController/Resources/pl.lproj/TOCropViewControllerLocalizable.strings +++ b/Objective-C/TOCropViewController/Resources/pl.lproj/TOCropViewControllerLocalizable.strings @@ -3,6 +3,6 @@ "Reset" = "Wyzeruj"; "Original" = "Orygin."; "Square" = "Kwadrat"; -"Delete Changes?" = "Usuń zmiany"; +"Delete Changes" = "Usuń zmiany"; "Yes" = "Tak"; "No" = "Nie"; diff --git a/Objective-C/TOCropViewController/Resources/pt.lproj/TOCropViewControllerLocalizable.strings b/Objective-C/TOCropViewController/Resources/pt.lproj/TOCropViewControllerLocalizable.strings index 9d02785f..a3774e18 100644 --- a/Objective-C/TOCropViewController/Resources/pt.lproj/TOCropViewControllerLocalizable.strings +++ b/Objective-C/TOCropViewController/Resources/pt.lproj/TOCropViewControllerLocalizable.strings @@ -3,6 +3,6 @@ "Reset" = "Redefinir"; "Original" = "Original"; "Square" = "Quadrada"; -"Delete Changes?" = "Apagar Alterações?"; +"Delete Changes" = "Apagar Alterações"; "Yes" = "Sim"; "No" = "Não"; diff --git a/Objective-C/TOCropViewController/Resources/ro.lproj/TOCropViewControllerLocalizable.strings b/Objective-C/TOCropViewController/Resources/ro.lproj/TOCropViewControllerLocalizable.strings index 3ead4041..8b9cb4aa 100644 --- a/Objective-C/TOCropViewController/Resources/ro.lproj/TOCropViewControllerLocalizable.strings +++ b/Objective-C/TOCropViewController/Resources/ro.lproj/TOCropViewControllerLocalizable.strings @@ -3,6 +3,6 @@ "Reset" = "Resetare"; "Original" = "Original"; "Square" = "Patrat"; -"Delete Changes?" = "Ștergeți modificările"; +"Delete Changes" = "Ștergeți modificările"; "Yes" = "Da"; "No" = "Nu"; diff --git a/Objective-C/TOCropViewController/Resources/ru.lproj/TOCropViewControllerLocalizable.strings b/Objective-C/TOCropViewController/Resources/ru.lproj/TOCropViewControllerLocalizable.strings index b485d4f7..c9188b25 100644 --- a/Objective-C/TOCropViewController/Resources/ru.lproj/TOCropViewControllerLocalizable.strings +++ b/Objective-C/TOCropViewController/Resources/ru.lproj/TOCropViewControllerLocalizable.strings @@ -3,6 +3,6 @@ "Reset" = "Сбросить"; "Original" = "Оригинал"; "Square" = "Квадрат"; -"Delete Changes?" = "Удалить изменения?"; +"Delete Changes" = "Удалить изменения"; "Yes" = "Да"; "No" = "Нет"; diff --git a/Objective-C/TOCropViewController/Resources/tr.lproj/TOCropViewControllerLocalizable.strings b/Objective-C/TOCropViewController/Resources/tr.lproj/TOCropViewControllerLocalizable.strings index 4d417202..0913b47e 100644 --- a/Objective-C/TOCropViewController/Resources/tr.lproj/TOCropViewControllerLocalizable.strings +++ b/Objective-C/TOCropViewController/Resources/tr.lproj/TOCropViewControllerLocalizable.strings @@ -3,7 +3,7 @@ "Reset" = "Sıfırla"; "Original" = "Orjinal"; "Square" = "Kare"; -"Delete Changes?" = "Değişiklikleri Sil"; +"Delete Changes" = "Değişiklikleri Sil"; "Yes" = "Evet"; "No" = "Hayır"; diff --git a/Objective-C/TOCropViewController/Resources/vi.lproj/TOCropViewControllerLocalizable.strings b/Objective-C/TOCropViewController/Resources/vi.lproj/TOCropViewControllerLocalizable.strings index d0d642b3..7826cc64 100644 --- a/Objective-C/TOCropViewController/Resources/vi.lproj/TOCropViewControllerLocalizable.strings +++ b/Objective-C/TOCropViewController/Resources/vi.lproj/TOCropViewControllerLocalizable.strings @@ -3,7 +3,7 @@ "Reset" = "Đặt lại"; "Original" = "Gốc"; "Square" = "Vuông"; -"Delete Changes?" = "Xóa Thay đổi?"; +"Delete Changes" = "Xóa Thay đổi"; "Yes" = "Có"; "No" = "Không"; diff --git a/Objective-C/TOCropViewController/Resources/zh-Hans.lproj/TOCropViewControllerLocalizable.strings b/Objective-C/TOCropViewController/Resources/zh-Hans.lproj/TOCropViewControllerLocalizable.strings index 828431c7..7b02b3ba 100644 --- a/Objective-C/TOCropViewController/Resources/zh-Hans.lproj/TOCropViewControllerLocalizable.strings +++ b/Objective-C/TOCropViewController/Resources/zh-Hans.lproj/TOCropViewControllerLocalizable.strings @@ -3,7 +3,7 @@ "Reset" = "重设"; "Original" = "原有"; "Square" = "正方形"; -"Delete Changes?" = "删除更改?"; +"Delete Changes" = "删除更改"; "Yes" = "是"; "No" = "否"; diff --git a/Objective-C/TOCropViewController/Resources/zh-Hant.lproj/TOCropViewControllerLocalizable.strings b/Objective-C/TOCropViewController/Resources/zh-Hant.lproj/TOCropViewControllerLocalizable.strings index b090d1f4..3dfe2b7f 100644 --- a/Objective-C/TOCropViewController/Resources/zh-Hant.lproj/TOCropViewControllerLocalizable.strings +++ b/Objective-C/TOCropViewController/Resources/zh-Hant.lproj/TOCropViewControllerLocalizable.strings @@ -3,7 +3,7 @@ "Reset" = "重置"; "Original" = "原始檔"; "Square" = "正方形"; -"Delete Changes?" = "刪除更動?"; +"Delete Changes" = "刪除更動"; "Yes" = "是"; "No" = "否"; From 7de4a544c6cde50f1fa2fc0340563fdc2e428b97 Mon Sep 17 00:00:00 2001 From: Tim Oliver Date: Mon, 8 Jul 2019 00:23:48 +0900 Subject: [PATCH 4/4] Updated CHANGELOG --- CHANGELOG.md | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 114c035a..3addd633 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,20 @@ x.y.z Release Notes (yyyy-MM-dd) ============================================================= +2.5.1 Release Notes (2019-07-08) +============================================================= + +## Added + +* Finnish Language Support ([#360](https://github.com/TimOliver/TOCropViewController/pull/360)) + +## Enhancements + +* Improved the UX of the cancellation dialog by changing the buttons from affirmative actions to explicit actions. ([#362](https://github.com/TimOliver/TOCropViewController/pull/362)) + +## Fixed +* A crash that would occur if the cancellation confirmation dialog was attempted to be displayed on iPad. ([#362](https://github.com/TimOliver/TOCropViewController/pull/362)) + 2.5.0 Release Notes (2019-04-21) =============================================================