Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish Implementing Credential Expiration #153

Open
mhrivnak opened this issue Apr 4, 2012 · 0 comments
Open

Finish Implementing Credential Expiration #153

mhrivnak opened this issue Apr 4, 2012 · 0 comments
Milestone
Alpha Release

Comments

@mhrivnak
Copy link
Member

mhrivnak commented Apr 4, 2012

CredentialType needs a new attribute named something like "duration". When a credential is created, its expiration date should be set that far into the future.

Furthermore, we need a new restriction: when checking for completion of a CredentialType, all required achievements must have been completed no more than duration ago. So if the duration is 1 year, it will:

  1. Check that all required achievements have been completed in the past year
  2. Set the date_expires attribute to one year from today.

Lastly, we need a daily task to be run by celery that looks for 'granted' credentials that should be set to expired and does so.
@ghost ghost assigned jc0n Apr 13, 2012
jc0n added a commit that referenced this issue Apr 14, 2012
@jc0n
Issue #153: Finish implementing Credential expiration
323c859 
- Allow setting all parameters when creating CredentialType
@jc0n jc0n mentioned this issue Apr 14, 2012
Merged
jc0n added a commit that referenced this issue Apr 14, 2012
@jc0n
Issue #153: Use days instead of seconds for credential duration
f3cb0a1
mhrivnak added a commit that referenced this issue Apr 17, 2012
@mhrivnak
re #153 the critical piece that was missing was any logic at create t…
5efc1b8 
…ime to actually mark the credential as granted. This commit adds that.
mhrivnak added a commit that referenced this issue Apr 17, 2012
@mhrivnak
re #153 The old fixutre was no longer loadable because the duration v…
0681cfd 
…alue was too large, following our switch to storing duration in days instead of seconds. The tests probably passed with sqlite since it doesn't have a smallint.
mhrivnak added a commit that referenced this issue Apr 18, 2012
@mhrivnak
re #153 refactored the create method so it makes more sensible use of…
ba27c7c 
… the Setter class. Previously it was just being lazy by adding a required attribute to the optional attributes dict and having setter do the work. This had a nasty side effect of making the RPC log entry look like the client passed 'credential_type' as an optional attribute.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Alpha Release
Development

No branches or pull requests
2 participants
@mhrivnak @jc0n