-
-
Notifications
You must be signed in to change notification settings - Fork 92
Migrate basic commands (ping, dbget, dbput) #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Heatmanofurioso
commented
Sep 15, 2021
- Add base Ping and Database Get&Set commands.
- Add initial integration and unit tests
- Remove old commands
application/src/main/java/org/togetherjava/tjbot/commands/CommandHandler.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/ReloadCommand.java
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/generic/DatabaseCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/generic/DatabaseCommand.java
Outdated
Show resolved
Hide resolved
application/src/test/java/org/togetherjava/tjbot/AbstractJDMock.java
Outdated
Show resolved
Hide resolved
application/src/test/java/org/togetherjava/tjbot/command/DatabaseCommandTest.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/CommandHandler.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/generic/DatabaseCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/generic/DatabaseCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/generic/DatabaseCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/generic/DatabaseCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/generic/PingCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/generic/PingCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/generic/PingCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/generic/DatabaseCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/generic/DatabaseCommand.java
Outdated
Show resolved
Hide resolved
@java-coding-prodigy Fixed according to your comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would result in a better user experience if you made usage of subcommands instead, also easier to maintain since it's 1 top-command instead of 2 (1 code-base, not multiple classes extending AbstractCommand)
application/src/main/java/org/togetherjava/tjbot/commands/example/AbstractCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/generic/DatabaseGetCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/generic/DatabaseGetCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/generic/DatabaseGetCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/generic/PingCommand.java
Outdated
Show resolved
Hide resolved
@Heatmanofurioso I know you are super busy and that is totally okay - can we get a rough ETA when you would plan to finish this? Otherwise we can probably put someone else on this to finish up what you already created :) |
Going to rebase this now. |
cdd312d
to
2ae03ed
Compare
I moved out a few things that should not be in here (mostly unit testing), those changes are now available in #152 and branch |
Done. @Tais993 |
- /ping - /db get key - /db put key value
db2c980
to
8f18863
Compare
Rewrote history, PR is now cleaned up and ready for merging. |
Kudos, SonarCloud Quality Gate passed! |