Skip to content

Migrate basic commands (ping, dbget, dbput) #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 30, 2021
Merged

Conversation

Heatmanofurioso
Copy link
Contributor

  • Add base Ping and Database Get&Set commands.
  • Add initial integration and unit tests
  • Remove old commands

@Heatmanofurioso Heatmanofurioso linked an issue Sep 15, 2021 that may be closed by this pull request
@Heatmanofurioso Heatmanofurioso self-assigned this Sep 15, 2021
@Heatmanofurioso Heatmanofurioso added this to the Improvement phase 1 milestone Sep 15, 2021
@Heatmanofurioso Heatmanofurioso marked this pull request as ready for review September 16, 2021 00:01
@Zabuzard Zabuzard added enhance command Modify or improve an existing command or group of commands of the bot and removed enhancement New feature or request labels Sep 16, 2021
@Heatmanofurioso
Copy link
Contributor Author

@java-coding-prodigy Fixed according to your comment.
Add it as a review next time, so I can mark it as solved

Copy link
Member

@Tais993 Tais993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would result in a better user experience if you made usage of subcommands instead, also easier to maintain since it's 1 top-command instead of 2 (1 code-base, not multiple classes extending AbstractCommand)

@Zabuzard
Copy link
Member

@Heatmanofurioso I know you are super busy and that is totally okay - can we get a rough ETA when you would plan to finish this? Otherwise we can probably put someone else on this to finish up what you already created :)

@Zabuzard
Copy link
Member

Going to rebase this now.

@Zabuzard Zabuzard force-pushed the feature/addPingCommand branch from cdd312d to 2ae03ed Compare September 29, 2021 14:09
@Heatmanofurioso Heatmanofurioso requested review from a team as code owners September 29, 2021 14:09
@Zabuzard Zabuzard self-assigned this Sep 29, 2021
Zabuzard
Zabuzard previously approved these changes Sep 29, 2021
@Zabuzard
Copy link
Member

I moved out a few things that should not be in here (mostly unit testing), those changes are now available in #152 and branch feature/add_jda_mock.

@Zabuzard
Copy link
Member

Would result in a better user experience if you made usage of subcommands instead, also easier to maintain since it's 1 top-command instead of 2 (1 code-base, not multiple classes extending AbstractCommand)

Done. @Tais993

@Zabuzard Zabuzard closed this Sep 29, 2021
@Zabuzard Zabuzard reopened this Sep 29, 2021
@Zabuzard Zabuzard requested a review from Tais993 September 29, 2021 16:27
Zabuzard
Zabuzard previously approved these changes Sep 29, 2021
@Zabuzard Zabuzard force-pushed the feature/addPingCommand branch from db2c980 to 8f18863 Compare September 29, 2021 16:40
Zabuzard
Zabuzard previously approved these changes Sep 29, 2021
@Zabuzard
Copy link
Member

Rewrote history, PR is now cleaned up and ready for merging.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Zabuzard Zabuzard changed the title Feature/add ping command Migrate basic commands (ping, dbget, dbput) Sep 29, 2021
@Zabuzard Zabuzard merged commit 0825986 into develop Sep 30, 2021
@Zabuzard Zabuzard deleted the feature/addPingCommand branch September 30, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhance command Modify or improve an existing command or group of commands of the bot priority: critical
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate base & test commands (!ping, !dbget, !dbput)
3 participants