Multithreading for command system #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zabuzard
requested review from
d3vel0per,
I-Al-Istannen,
marko-radosavljevic,
illuminator3 and
Tais993
|
I am not sure that throwing those into the common fork join pool is a good idea (particularly the reload commands)? |
As discussed in Discord, I had a misunderstanding. Will use the cached pool with the next commit 👍 |
I-Al-Istannen
previously approved these changes
Oct 8, 2021
Tais993
previously approved these changes
Oct 8, 2021
* long running commands must not block other commands or processes. to ensure that, everything is now executed multithreaded
GUILD_SIZE_PARALLEL_THRESHOLD -> GUILDS_AMOUNT_PARALLEL_THRESHOLD
Zabuzard
force-pushed
the
feature/multithreading_command_system
branch
from
82e41b7 to
1c352b1
Compare
|
Rebased on |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long running commands must not block other commands or processes. To ensure that, commands and guild updates are now executed multithreaded.
Port from the stale #119 which did not survive the massive refactoring introduced in
develop.