Make code actions autodetection not trigger for top helpers+ #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
|
Ran the checks for you. Make sure to run spotless with It should be done automatically if you built the project at least once, with a git pre-commit hook. |
Contributor
Author
|
Thank you for your response. I will fix this.
Marko Radosavljević ***@***.***> schrieb am Mo., 26. Dez.
2022, 11:37:
… Ran the checks for you. Make sure to run spotless with ./gradlew
spotlessApply in the root project directory or gradle task spotlessApply
in your IDE. ^^
It should be done automatically if you built the project at least once,
with a git pre-commit hook.
—
Reply to this email directly, view it on GitHub
<#733 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQ5AJWMW6B22N6QFP2UWEWDWPFYOPANCNFSM6AAAAAATJQ4KO4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
Author
|
I ran ./gradlew spotlessApply and gradle build. Builds successful. Hope this is enough to match the workflow requirements. |
Taz03
requested changes
Dec 26, 2022
application/src/main/java/org/togetherjava/tjbot/commands/code/CodeMessageAutoDetection.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/code/CodeMessageAutoDetection.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/code/CodeMessageAutoDetection.java
Outdated
Show resolved
Hide resolved
Member
|
u'll need to sign the cla too |
role pattern comes now from config file instead of hardcoded;
Taz03
requested changes
Dec 26, 2022
application/src/main/java/org/togetherjava/tjbot/commands/code/CodeMessageAutoDetection.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/code/CodeMessageAutoDetection.java
Outdated
Show resolved
Hide resolved
…fig.java; renamed and adjusted isCodeActionIgnored;
Taz03
requested changes
Dec 27, 2022
application/src/main/java/org/togetherjava/tjbot/commands/code/CodeMessageAutoDetection.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/code/CodeMessageAutoDetection.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/code/CodeMessageAutoDetection.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/code/CodeMessageAutoDetection.java
Outdated
Show resolved
Hide resolved
removed not needed variable declaration;
Taz03
previously approved these changes
Dec 27, 2022
Member
Taz03
left a comment
Taz03
left a comment
There was a problem hiding this comment.
looks good to me, make sure to test it tho
Contributor
marko-radosavljevic
left a comment
marko-radosavljevic
left a comment
There was a problem hiding this comment.
Looks good. Just some minor changes and naming.
application/src/main/java/org/togetherjava/tjbot/commands/code/CodeMessageAutoDetection.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/code/CodeMessageAutoDetection.java
Outdated
Show resolved
Hide resolved
refactored variable names in CodeMessageAutoDetection;
CodePawfect
requested review from
marko-radosavljevic
and removed request for
marko-radosavljevic
CodePawfect
requested review from
Taz03 and
marko-radosavljevic
and removed request for
Taz03 and
marko-radosavljevic
CodePawfect
requested review from
Taz03 and
marko-radosavljevic
and removed request for
Taz03 and
marko-radosavljevic
application/src/main/java/org/togetherjava/tjbot/commands/code/CodeMessageAutoDetection.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/code/CodeMessageAutoDetection.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/code/CodeMessageAutoDetection.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/code/CodeMessageAutoDetection.java
Outdated
Show resolved
Hide resolved
Taz03
approved these changes
Dec 30, 2022
marko-radosavljevic
changed the title
Merged
marko-radosavljevic
pushed a commit
that referenced
this pull request
Jan 8, 2023
* Adjust onMessageReceived conditions to ignore codeformatting bot responses for Top Helpers role
Fede923
pushed a commit
to Fede923/TJ-Bot
that referenced
this pull request
Jan 21, 2023
…r-Java#733) * Adjust onMessageReceived conditions to ignore codeformatting bot responses for Top Helpers role
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #719
This pull request includes the following changes:
In the application/config.json.template file, a new key called ignoreMessageAutoDetectionRolePattern has been added.
In the CodeMessageAutoDetection.java file, a new method called isSentByIgnoredMember has been added to check if a message was sent by a member with a role that matches the ignoreMessageAutoDetectionRolePattern specified in the configuration.
In the Config.java file, a new field called ignoreMessageAutoDetectionRolePattern has been added to the Config class.
These changes allow for the configuration of a role pattern that will be used to ignore messages from members with matching roles in the CodeMessageAutoDetection feature. This can be useful for preventing certain roles from triggering code message detection and handling.
Screenshots:
"Code action autodetection is triggered by a user without roles (User catlitter)"
"Code action autodetection is not triggered by a user with Top Helpers Role (User mdyingstar)"