Skip to content

Top helpers not askers #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 7, 2023
Merged

Top helpers not askers #763

merged 4 commits into from
Feb 7, 2023

Conversation

@Taz03
Copy link
Member

@Taz03 Taz03 commented Feb 3, 2023

closes #762

@Taz03 Taz03 requested review from a team as code owners February 3, 2023 19:43
@Taz03 Taz03 self-assigned this Feb 3, 2023
@Taz03 Taz03 added the enhancement New feature or request label Feb 3, 2023
@Zabuzard
Copy link
Member

Zabuzard commented Feb 6, 2023

TopHelper unit tests crash, because you introduced new methods into the flow that havent been mocked yet. Do you want to fix this urself or should someone else take that part over?

@Zabuzard
Copy link
Member

Zabuzard commented Feb 6, 2023

Has to be done in the JdaTestHelper main class or whatever its called

@Taz03
Copy link
Member Author

Taz03 commented Feb 6, 2023

TopHelper unit tests crash, because you introduced new methods into the flow that havent been mocked yet. Do you want to fix this urself or should someone else take that part over?

i haven't tried yet, i'll like to try that myself first, will update on it

@Taz03
Copy link
Member Author

Taz03 commented Feb 6, 2023

@Zabuzard for some reason when i use shorthand method it passes the test, is it ok?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Zabuzard
Copy link
Member

Zabuzard commented Feb 7, 2023

i suppose that method is mocked already - lol!

fair enough, i guess

@Zabuzard Zabuzard merged commit 1161b88 into develop Feb 7, 2023
@Zabuzard Zabuzard deleted the feature/top-helpers-not-askers branch February 7, 2023 15:03
@Zabuzard Zabuzard mentioned this pull request Mar 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zabuzard Zabuzard Zabuzard approved these changes

@SquidXTV SquidXTV SquidXTV approved these changes

Assignees

@Taz03 Taz03

Labels

enhancement New feature or request priority: normal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Exclude OP (askers) from TopHelpersMessageListener

4 participants

@Taz03 @Zabuzard @SquidXTV