Skip to content

Conversation

@hamzanaciri99
Copy link
Contributor

@hamzanaciri99 hamzanaciri99 commented Mar 9, 2023

Pull-request

Changes

  • Existing code
  • New feature

Closes Issue: #645

Description

Add modal for users to write their message, the command still accepts guild and "Wants to stay anonymous" as parameters, only message has been moved into the modal.

The new command looks like this:




@hamzanaciri99 hamzanaciri99 requested review from a team as code owners March 9, 2023 23:01
@CLAassistant
Copy link

CLAassistant commented Mar 9, 2023

CLA assistant check
All committers have signed the CLA.

@Taz03
Copy link
Member

Taz03 commented Mar 10, 2023

i'd say keep the anonymous field in the modal as well, what do u guys think?

@Zabuzard Zabuzard linked an issue Mar 10, 2023 that may be closed by this pull request
@Zabuzard Zabuzard added enhance command Modify or improve an existing command or group of commands of the bot priority: normal labels Mar 10, 2023
@hamzanaciri99 hamzanaciri99 requested review from Taz03 and Zabuzard and removed request for Taz03 and Zabuzard March 10, 2023 09:27
@Taz03
Copy link
Member

Taz03 commented Mar 10, 2023

i'd say keep the anonymous field in the modal as well, what do u guys think?

@Zabuzard what about this?

@hamzanaciri99
Copy link
Contributor Author

i'd say keep the anonymous field in the modal as well, what do u guys think?

Wouldn't it be ambiguous for users? the current one gives options, they would have to type yes or no, but users who used it before may type true and false instead.
It would be nice if we could validate user input before submitting, and show a message if the input in invalid (!= yes/no)

@Taz03
Copy link
Member

Taz03 commented Mar 10, 2023

the current one gives options, they would have to type yes or no, but users who used it before may type true and false instead.

we can accept everything from y/n, yes/no, t/f, true/false

It would be nice if we could validate user input before submitting

unfortunately that is not possible

@Zabuzard
Copy link
Member

if modals support dropdowns, i would want to move as much as possible into it. if thats not an option, i would rather want to keep it as slash-command. dont want to have input-parsing y/n/yes/no/... on that honestly. in particular if we have a slash-command input already anyways due to the guild-dropdown (unless modals have dropdowns)

@Zabuzard Zabuzard merged commit 5dbe008 into Together-Java:develop Mar 11, 2023
@Zabuzard
Copy link
Member

Awesome, thanks for your contribution ❤️ Are you on our Discord? If so, could you tell me your account name, then I can give you the contributor badge 👍

@hamzanaciri99
Copy link
Contributor Author

Thank you @Zabuzard for your kind words.
Yes, I am on your Discord, my name is Rimuru.

@Taz03
Copy link
Member

Taz03 commented Mar 11, 2023

i can see 2 Rimuru in discord, pls tell ur tag as well

@hamzanaciri99
Copy link
Contributor Author

Rimuru#2995

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhance command Modify or improve an existing command or group of commands of the bot priority: normal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/modmail modal support

4 participants