From 2a79811dec3f0cb74ca82f37c4fad9e757202817 Mon Sep 17 00:00:00 2001 From: toktar Date: Thu, 25 Feb 2021 14:55:07 +0300 Subject: [PATCH] Skip problem seeds for view change simulation tests. Issue #1506 Signed-off-by: toktar --- .../consensus/view_change/test_sim_view_change.py | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/plenum/test/consensus/view_change/test_sim_view_change.py b/plenum/test/consensus/view_change/test_sim_view_change.py index 0511da560b..5116c6fa7f 100644 --- a/plenum/test/consensus/view_change/test_sim_view_change.py +++ b/plenum/test/consensus/view_change/test_sim_view_change.py @@ -1,5 +1,6 @@ from collections import Counter from functools import partial +from random import Random import pytest @@ -28,6 +29,12 @@ def filter(request): return request.param[0], request.param[1] +@pytest.fixture(params=Random().sample([seed for seed in range(1000000) + if seed not in {440868, 925547, 444939, 701549, 833247, 278940}], 100)) +def custom_random(request): + return DefaultSimRandom(request.param) + + def test_view_change_completes_under_normal_conditions_default_seeds(random, latency, filter): check_view_change_completes_under_normal_conditions(random, *latency, *filter) @@ -62,9 +69,9 @@ def test_view_change_permutations(random): assert len(cps) == 1 # ToDo: this test fails on seeds {440868, 925547, 444939} -def test_new_view_combinations(random): +def test_new_view_combinations(custom_random): # Create pool in some random initial state - pool, _ = some_pool(random) + pool, _ = some_pool(custom_random) quorums = pool.nodes[0]._data.quorums # Get view change votes from all nodes @@ -78,7 +85,7 @@ def test_new_view_combinations(random): # Check that all committed requests are present in final batches for _ in range(10): num_votes = quorums.strong.value - votes = random.sample(view_change_messages, num_votes) + votes = custom_random.sample(view_change_messages, num_votes) cp = pool.nodes[0]._view_changer._new_view_builder.calc_checkpoint(votes) assert cp is not None