Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save dark and flat fields in nexus file produced with NEXUSDataWriter #934

Closed
lauramurgatroyd opened this issue Jul 21, 2021 · 1 comment
Assignees
Milestone

Comments

@lauramurgatroyd
Copy link
Member

The NXTomo format has the flat and dark fields included in the data, with a key to specify the indices where they are located.

We would like to read in an NXTomo file and write out a nexus file with the NEXUSDataWriter, without losing the information about the dark and flat fields.

The NEXUSDataWriter currently writes the dataset to:

ds_data = f.create_dataset('entry1/tomo_entry/data/data',

We could either:

  • Write the dark and flat fields there along with the data, and also save the key. Other nexus files previously written out with the NEXUSDataWriter won't have a key, but in the NEXUSDataReader we could assume no dark and flat fields are present in the data in the case that a key doesn't exist.

or

  • Save the dark and flat fields as separate entries in the nexus file, along with a list of angles where they were taken.
@lauramurgatroyd
Copy link
Member Author

Closing this, because instead of writing dark and flat fields to the CIL Nexus file, we are going to keep the data as NXTomo format until we get to a processing step (e.g. Centre of Rotation Correction) where we need to specifically write out CIL info (such as the geometry). The other steps just modify the data which will be saved in an NXTomo anyway.
Therefore we will just need the NXTomo reader and writers (see #939 and #949)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants