Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Models dropdown #1321

Merged
merged 5 commits into from
Oct 6, 2023
Merged

Models dropdown #1321

merged 5 commits into from
Oct 6, 2023

Conversation

namansleeps
Copy link
Collaborator

Description

Related Issues

Solution and Design

Test Plan

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update

Checklist

  • My pull request is atomic and focuses on a single change.
  • I have read the contributing guide and my code conforms to the guidelines.
  • I have documented my changes clearly and comprehensively.
  • I have added the required tests.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2da4f0e) 58.84% compared to head (6054749) 58.84%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1321   +/-   ##
=======================================
  Coverage   58.84%   58.84%           
=======================================
  Files         228      228           
  Lines       11063    11063           
  Branches     1189     1189           
=======================================
  Hits         6510     6510           
  Misses       4222     4222           
  Partials      331      331           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jedan2506 jedan2506 merged commit 95482ba into main Oct 6, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants