You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
As the storybook docs import from README.md, the link refers to './CONTRIBUTING.md' which works on github but on StoryBook it redirects to 'https://baklava.design/CONTRIBUTING.md' which naturally results in 404.
To Reproduce
Steps to reproduce the behavior:
Go to baklava.design
Click on 'For more information please check our [Contribution Guideline document]'
See error
Expected behavior
Ideally the link should refer depending on whether clicked from github or storybook. However as the markdown file is imported directly, I couldn't manage to add that logic without seperating the link between github and storybook docs.
Proposed Solution
Only working solution I could come up without creating the need to update both files seperately is to use absolute paths rather than relative, and have both github and storybook links avaliable: For more information please check our [Contribution Guideline document on GitHub](https://github.com/Trendyol/baklava/blob/next/CONTRIBUTING.md), or [on Storybook](https://baklava.design/?path=/docs/documentation-contributing-baklava-contribution-guideline--page).
Describe the bug
As the storybook docs import from README.md, the link refers to './CONTRIBUTING.md' which works on github but on StoryBook it redirects to 'https://baklava.design/CONTRIBUTING.md' which naturally results in 404.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Ideally the link should refer depending on whether clicked from github or storybook. However as the markdown file is imported directly, I couldn't manage to add that logic without seperating the link between github and storybook docs.
Proposed Solution
Only working solution I could come up without creating the need to update both files seperately is to use absolute paths rather than relative, and have both github and storybook links avaliable:
For more information please check our [Contribution Guideline document on GitHub](https://github.com/Trendyol/baklava/blob/next/CONTRIBUTING.md), or [on Storybook](https://baklava.design/?path=/docs/documentation-contributing-baklava-contribution-guideline--page).
For more information please check our Contribution Guideline document on GitHub, or on Storybook.
Screenshots
404 page:
working solution:
The text was updated successfully, but these errors were encountered: