Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Checkbox's position:absolute value is taken from the entire page #895

Closed
1 task
erbilnas opened this issue Jul 11, 2024 · 2 comments · Fixed by #896
Closed
1 task

[BUG]: Checkbox's position:absolute value is taken from the entire page #895

erbilnas opened this issue Jul 11, 2024 · 2 comments · Fixed by #896
Assignees
Labels
bug Something isn't working bug-confirmed When bug confirmed by the maintainers released

Comments

@erbilnas
Copy link
Collaborator

Issue description

When the checkbox is wrapped with a dialog, it should take its position relative to the height of the dialog, not the page.

https://stackblitz.com/edit/vue2-vite-starter-ncdgf1?file=index.html,src%2FApp.vue

Media & Screenshots

With position:absolute

Screenshot 2024-07-11 at 10 22 40

Without position:absolute

Screenshot 2024-07-11 at 10 22 58
Screenshot 2024-07-11 at 10 22 52

Baklava Version

3.0.0-beta.14

Operating system

No response

Priority this issue should have

Medium (should be fixed soon)

Please review the checkboxes that are applicable.

  • This issue is directly related to React
@erbilnas erbilnas added bug Something isn't working bug-confirmed When bug confirmed by the maintainers labels Jul 11, 2024
@erbilnas
Copy link
Collaborator Author

Imho, we should add

position: absolute;

on input instead of .check-mark

input[type="checkbox"] {
  appearance: none;
  outline: none;
  margin: 0;
  box-sizing: border-box;
  border: 1px solid var(--bl-color-neutral-lighter);
  border-radius: var(--bl-border-radius-xs);
  width: var(--bl-size-m);
  height: var(--bl-size-m);
  min-width: var(--bl-size-m);
  min-height: var(--bl-size-m);
  max-width: var(--bl-size-m);
  max-height: var(--bl-size-m);
}

.check-mark {
  position: absolute;
  display: flex;
  align-items: center;
  justify-content: center;
@@ -43,6 +58,38 @@ input {
  background-color: var(--bl-color-neutral-full);
}

Copy link

🎉 This issue has been resolved in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bug-confirmed When bug confirmed by the maintainers released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant