-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update eslint/prettier configs #657
Conversation
Should we disable whitespace-sensitive formatting? Other than that, lgtm. Eline sağlık. |
Each file seem to have its own parser according to Prettier, also this blog post is from 2018 so I have doubts it does have an effect on us. Unit tests also does pass. |
Added 2 new eslint plugins for web components & lit. Additionally they helped me to identify some errors at existing components and tests. |
I meant as a styling choice. I don't really like current span formatting but, it also prevents unwanted spacing issue. That being said, If the spacing doesn't matter, we can just add spaces before and after the text and it will format regularly. So, no big deal. |
I see. Just to confirm, what is the option for this config? const content = this.embedUrl
? html`<iframe src=${this.embedUrl}></iframe>`
: html`<slot></slot>`; const content = this.embedUrl
? html`
<iframe src=${this.embedUrl}></iframe>
`
: html`
<slot></slot>
`; ... const inputSelectedOptions = html`<ul class="selected-options">
${this._selectedOptions.map(item => html`<li>${item.textContent}</li>`)}
</ul>`; const inputSelectedOptions = html`
<ul class="selected-options">
${this._selectedOptions.map(
item =>
html`
<li>${item.textContent}</li>
`
)}
</ul>
`; |
🎉 This PR is included in version 2.3.0-beta.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Updates the following:
Adds
New eslint plugins helped me to notice & fix some errors at components. See 665a03c.