From 3531ca6d2e2b5b9279ad3a7c63c1bf49e8edcdb1 Mon Sep 17 00:00:00 2001 From: onurravli Date: Tue, 29 Aug 2023 01:58:03 +0300 Subject: [PATCH 1/2] fix(storybook): fix commit rules documentation link --- docs/design-system/adding-a-new-icon.stories.mdx | 2 +- docs/linting.stories.mdx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/design-system/adding-a-new-icon.stories.mdx b/docs/design-system/adding-a-new-icon.stories.mdx index fa11e343..0e0b1f00 100644 --- a/docs/design-system/adding-a-new-icon.stories.mdx +++ b/docs/design-system/adding-a-new-icon.stories.mdx @@ -40,7 +40,7 @@ import prFormImage from '../images/pr-form.png'; -12. Write your commit message in the Message input. We are using some [commit rules](/docs/documentation-commit-rules--page) so you need to follow same rules. Most of the cases for adding new icon you'll use `feat(icon): name icon added` format. Write your message and click tick button above (or Ctrl + Enter) for sending your changes to GitHub. +12. Write your commit message in the Message input. We are using some [commit rules](/docs/documentation-contributing-baklava-commit-rules--documentation) so you need to follow same rules. Most of the cases for adding new icon you'll use `feat(icon): name icon added` format. Write your message and click tick button above (or Ctrl + Enter) for sending your changes to GitHub. diff --git a/docs/linting.stories.mdx b/docs/linting.stories.mdx index a5fe86d2..22f7cbfe 100644 --- a/docs/linting.stories.mdx +++ b/docs/linting.stories.mdx @@ -10,7 +10,7 @@ Linters that we use are [`eslint`](https://eslint.org), [`stylelint`](https://st [`commitlint`](https://commitlint.js.org). When make a git commit, some staged files processed with linters (via [`husky`](https://typicode.github.io/husky/)) to check some syntax issues. `eslint` run for `ts` and `js` files and `stylelint` run for `css` files. Also we check commit message with `commitlint`. [More information about our commit -rules](/docs/documentation-commit-rules--page). If there are any issues commit will be +rules](/docs/documentation-contributing-baklava-commit-rules--documentation). If there are any issues commit will be interrupted with the message. Same rules also apply in pipeline flow for every push. In the pipelines, we run `npm run lint` which is doing same From 00c0e68a47733c7d1fd8726bb435898f2456b030 Mon Sep 17 00:00:00 2001 From: onurravli Date: Tue, 29 Aug 2023 02:04:03 +0300 Subject: [PATCH 2/2] docs(storybook): fix a typo in badge stories --- src/components/badge/bl-badge.stories.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/badge/bl-badge.stories.mdx b/src/components/badge/bl-badge.stories.mdx index 27355f84..72ba6598 100644 --- a/src/components/badge/bl-badge.stories.mdx +++ b/src/components/badge/bl-badge.stories.mdx @@ -107,7 +107,7 @@ And you can only add icon for `large` or `medium` badge. ## Sizing Badges -We have 3 sizes of buttons: `large`, `medium`, `small`. Default size is `medium`. +We have 3 sizes of badges: `large`, `medium`, `small`. Default size is `medium`.