Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkbox): breaking long words better #694

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

muratcorlu
Copy link
Contributor

@muratcorlu muratcorlu commented Sep 8, 2023

This PR proposes to use overflow-wrap: anywhere for checkbox label instead of word-break: break-all to provide better readability in case of long texts in small available space.

Fixes #682
Fixes #626

@muratcorlu muratcorlu linked an issue Sep 8, 2023 that may be closed by this pull request
1 task
@AykutSarac
Copy link
Member

Do we consider this a breaking change and release in the next major?

@muratcorlu
Copy link
Contributor Author

Do we consider this a breaking change and release in the next major?

I don't see a visual design change here, this is just a fix for an issue that we had unintentionally. I can not imagine anyone will prefer the current version over this fix.

@muratcorlu muratcorlu merged commit c802ec8 into next Sep 12, 2023
4 checks passed
@muratcorlu muratcorlu deleted the 682-bug-checkbox-whitespace branch September 12, 2023 11:59
@github-actions
Copy link

🎉 This PR is included in version 2.3.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@AykutSarac AykutSarac mentioned this pull request Oct 12, 2023
@github-actions
Copy link

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Checkbox whitespace [BUG]: multiple select option text overflow
3 participants