Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): lit version upgrade #696

Merged
merged 3 commits into from
Sep 12, 2023
Merged

chore(deps): lit version upgrade #696

merged 3 commits into from
Sep 12, 2023

Conversation

muratcorlu
Copy link
Contributor

This PR upgrades Lit to 2.8

@muratcorlu muratcorlu requested review from a team, Enes5519 and DamlaDemir and removed request for a team September 8, 2023 14:03
@AykutSarac
Copy link
Member

I think we can upgrade @lit-labs/react with this PR.

@muratcorlu
Copy link
Contributor Author

@AykutSarac there is a breaking change on @lit-labs/react library which needs some code changes. I think it'll be better to have it in a separate PR. https://github.com/lit/lit/blob/main/packages/labs/react/CHANGELOG.md

@AykutSarac
Copy link
Member

@AykutSarac there is a breaking change on @lit-labs/react library which needs some code changes. I think it'll be better to have it in a separate PR. https://github.com/lit/lit/blob/main/packages/labs/react/CHANGELOG.md

IIRC I've tried with the latest including the breaking change and it didn't effect the output. I agree it better be in a separate PR.

@muratcorlu muratcorlu merged commit a89109e into next Sep 12, 2023
4 checks passed
@muratcorlu muratcorlu deleted the lit-upgrade branch September 12, 2023 12:39
@github-actions
Copy link

🎉 This PR is included in version 2.3.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@AykutSarac AykutSarac mentioned this pull request Oct 12, 2023
Merged
@github-actions
Copy link

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AykutSarac AykutSarac AykutSarac approved these changes

@Enes5519 Enes5519 Awaiting requested review from Enes5519 Enes5519 was automatically assigned from Trendyol/baklava-web

@DamlaDemir DamlaDemir Awaiting requested review from DamlaDemir DamlaDemir was automatically assigned from Trendyol/baklava-web

Assignees
No one assigned
Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muratcorlu @AykutSarac