diff --git a/src/tribler/gui/network/request.py b/src/tribler/gui/network/request.py index 4a1fe7e7a7a..e019a3d39c6 100644 --- a/src/tribler/gui/network/request.py +++ b/src/tribler/gui/network/request.py @@ -104,7 +104,7 @@ def on_finished(self): return if not data: - self.on_finished_signal.emit({}) + self.logger.error(f'No data received in the reply for {self}') return self.logger.debug('Create a json response') diff --git a/src/tribler/gui/network/tests/test_request.py b/src/tribler/gui/network/tests/test_request.py index a6b5bcd0cbc..8aef3f7c962 100644 --- a/src/tribler/gui/network/tests/test_request.py +++ b/src/tribler/gui/network/tests/test_request.py @@ -40,7 +40,7 @@ def test_str_data_constructor(): def test_on_finished(): # Test that if 'request.reply' is empty, the `on_finish` method is called with an empty dict. - # see: https://github.com/Tribler/tribler/issues/7297 + # see: https://github.com/Tribler/tribler/issues/7333 on_success = MagicMock() request = Request(endpoint='endpoint', on_success=on_success) request.manager = MagicMock() @@ -48,4 +48,4 @@ def test_on_finished(): request.on_finished() - on_success.assert_called_once_with({}) + on_success.assert_not_called()