Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic syntax highlight support for code blocks #526

Merged
merged 74 commits into from
Nov 1, 2024

Conversation

eliandoran
Copy link
Contributor

@eliandoran eliandoran commented Oct 27, 2024

Syntax highlighting & word wrapping for code blocks

Finally, syntax highlighting was added as a feature for code blocks:

1_Syntax highlighting   word wra

Context

In order to achieve the syntax highlight, the Highlight.js library is being used. Do note that support for syntax highlighting in code blocks is not a supported feature of the text editor we are using CKEditor), but rather a hack which makes use of the highlights API (used for highlighting search results for example). Nevertheless, we haven't noticed any major issues during the development of the feature, but feel free to report any issues you might have.

Most of the work to achieve the syntax highlight itself was already done by antoniotejada in https://github.com/antoniotejada/Trilium-SyntaxHighlightWidget. On our side we added customization but also additional functionality.

Migrating from existing syntax highlight plugins

If you are already using a syntax highlighting plugin such as the Trilium-SyntaxHighlightWidget we are basing off of, it is important to disable that plugin before upgrading in order for it not to conflict with our implementation.

Should you encounter any issues after the migration, try running Trilium in safe mode.

New section in settings

In order to configure this new feature, a section has been added in Options → Appearance to control the syntax highlighting. There the color scheme can be chosen, from a builtin selection of themes from Highlight.js.

It is also now possible to disable the word wrapping for code blocks, which can make them easier to read for large amounts of code. Word wrapping has now been disabled by default.

It is also possible to disable the syntax highlighting by selecting “No syntax highlighting” in the “Color scheme” option.

Syntax highlighting   word wra

Using the syntax highlight in auto mode

Provided the syntax highlighting is enabled in the settings, simply create a code block within a text note and it will try to automatically detect the language (using the Highlight.js library):

2_Syntax highlighting   word wra

Adjusting the language manually

Should the automatic syntax highlight not work well enough, it is possible to manually adjust the language of the code block:

3_Syntax highlighting   word wra

Adding support for new languages

By going to settings → Code Notes → Available MIME types in the dropdown, it is possible to adjust the languages that are used for code blocks as well.

Note that not all languages that are present in this list (which is meant for code blocks, using CodeMirror as editor) are supported by our syntax highlight library. In this case you will simply see no syntax highlighting when you select the language.

If syntax highlighting is not supported for a given language, feel free to open an issue and we will look whether it is possible to integrate it.

Automatic disable of syntax highlighting

Note that when editing a text note, syntax highlighting is automatically disabled if the code block is too big (somewhere around 500 lines). This value is currently not configured.

For read-only text notes, this limitation is not applied.

@eliandoran eliandoran marked this pull request as ready for review November 1, 2024 23:43
@eliandoran eliandoran merged commit f37fa37 into develop Nov 1, 2024
1 check passed
@eliandoran eliandoran deleted the feature/syntax_highlight branch November 1, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants