From 444bf6526c398ab99df82fb94839d2162519ba16 Mon Sep 17 00:00:00 2001 From: Philipp Salvisberg Date: Fri, 12 Aug 2022 10:12:08 +0200 Subject: [PATCH 1/2] add missing into_clause in G-8310 examples --- .../8-patterns/3-validating-input-parameter-size/g-8310.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/4-language-usage/8-patterns/3-validating-input-parameter-size/g-8310.md b/docs/4-language-usage/8-patterns/3-validating-input-parameter-size/g-8310.md index 4c3e597b..37cbff4f 100644 --- a/docs/4-language-usage/8-patterns/3-validating-input-parameter-size/g-8310.md +++ b/docs/4-language-usage/8-patterns/3-validating-input-parameter-size/g-8310.md @@ -20,6 +20,7 @@ create or replace package body department_api is end if; -- get the department by name select * + into l_return from departments where department_name = in_dept_name; @@ -40,6 +41,7 @@ create or replace package body department_api is begin -- get the department by name select * + into l_return from departments where department_name = l_dept_name; From b5b6e54d94ffffd2ddbdab2c3e7860c0a431939e Mon Sep 17 00:00:00 2001 From: Philipp Salvisberg Date: Fri, 12 Aug 2022 10:14:48 +0200 Subject: [PATCH 2/2] rename variable l_return to r_return to match naming conventions --- .../3-validating-input-parameter-size/g-8310.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/4-language-usage/8-patterns/3-validating-input-parameter-size/g-8310.md b/docs/4-language-usage/8-patterns/3-validating-input-parameter-size/g-8310.md index 37cbff4f..1993ddb7 100644 --- a/docs/4-language-usage/8-patterns/3-validating-input-parameter-size/g-8310.md +++ b/docs/4-language-usage/8-patterns/3-validating-input-parameter-size/g-8310.md @@ -13,18 +13,18 @@ This technique raises an error (`value_error`) which may not be handled in the c create or replace package body department_api is function dept_by_name(in_dept_name in departments.department_name%type) return departments%rowtype is - l_return departments%rowtype; + r_return departments%rowtype; begin if in_dept_name is null or length(in_dept_name) > 20 then raise err.e_param_to_large; end if; -- get the department by name select * - into l_return + into r_return from departments where department_name = in_dept_name; - return l_return; + return r_return; end dept_by_name; end department_api; / @@ -37,15 +37,15 @@ create or replace package body department_api is function dept_by_name(in_dept_name in departments.department_name%type) return departments%rowtype is l_dept_name departments.department_name%type not null := in_dept_name; - l_return departments%rowtype; + r_return departments%rowtype; begin -- get the department by name select * - into l_return + into r_return from departments where department_name = l_dept_name; - return l_return; + return r_return; end dept_by_name; end department_api; /