Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set published at & published by #117

Closed
ErisDS opened this issue Jun 6, 2013 · 9 comments
Closed

Set published at & published by #117

ErisDS opened this issue Jun 6, 2013 · 9 comments
Assignees
Milestone

Comments

@ErisDS
Copy link
Member

ErisDS commented Jun 6, 2013

Published at and published by need to be set when the post status changes from draft to published. At the moment we are not able to tell if the status is changing now in the saving function.

I know this is a bookshelf issue (can/should the models have "changing" like in Backbone?) but hopefully you won't mind doing this when it's done.

@ghost ghost assigned tgriesser Jun 6, 2013
@tgriesser
Copy link
Contributor

I've been working on a branch of Bookshelf that adds in support for changing/hasChanged/previousAttributes, it's mostly done, just need to write tests - hope to have that finished up soon.

@ErisDS
Copy link
Member Author

ErisDS commented Jun 8, 2013

That sounds fantastic, I'm looking forward to getting my hands on it and getting to grips with the models even more :)

@tgriesser
Copy link
Contributor

(Finally) Just published a new version... let me know if you want me to take a shot at the rest of what's left in this and any other model related tickets (#101, #118).

@ErisDS
Copy link
Member Author

ErisDS commented Jun 11, 2013

Would be fantastic if you could jump in, update our bookshelf and get this one finished up :)

@tgriesser
Copy link
Contributor

Good deal... Will take a look today.

@tgriesser
Copy link
Contributor

Getting to this now.

@ErisDS
Copy link
Member Author

ErisDS commented Jun 15, 2013

How are you getting on with this one? It's super high priority - are you working on it or shall I grab it?

@tgriesser
Copy link
Contributor

I was sort of looking at how the "updated_by" would work... right now there's no concept of access control in the sense that none of the requests to the api layer are actually performed by a user, or check to see who's doing it... they only check that the user is logged in. So I guess the updated_by would have to be a part of however that's going to be handled with the ACL piece... Just opened a PR for published_at

@ErisDS
Copy link
Member Author

ErisDS commented Jun 16, 2013

When I made my updates for #101 I added orderby published_at desc which seemed to have worked. Now it isn't working because, I think, it seems to be being quoted as "published_at desc" in the SQL. I'm gonna do some more digging myself, but if you happen to see this and know the answer plz let me know.

@ErisDS ErisDS closed this as completed in 17c8c02 Jun 16, 2013
morficus pushed a commit to morficus/Ghost that referenced this issue Sep 4, 2014
Fixes the knex query so that posts are correctly returned in the order of published_at, desc
daniellockyer pushed a commit that referenced this issue Jul 26, 2022
closes #117

- Having immediately executable offloaded jobs is necessary to be able to run usecases like: send batched emails now, or any other job that does not need to be scheduled
- Changed "simple" job timeout to make tests run faster
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants