-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set published at & published by #117
Comments
I've been working on a branch of Bookshelf that adds in support for changing/hasChanged/previousAttributes, it's mostly done, just need to write tests - hope to have that finished up soon. |
That sounds fantastic, I'm looking forward to getting my hands on it and getting to grips with the models even more :) |
Would be fantastic if you could jump in, update our bookshelf and get this one finished up :) |
Good deal... Will take a look today. |
Getting to this now. |
How are you getting on with this one? It's super high priority - are you working on it or shall I grab it? |
I was sort of looking at how the "updated_by" would work... right now there's no concept of access control in the sense that none of the requests to the api layer are actually performed by a user, or check to see who's doing it... they only check that the user is logged in. So I guess the |
When I made my updates for #101 I added orderby published_at desc which seemed to have worked. Now it isn't working because, I think, it seems to be being quoted as "published_at desc" in the SQL. I'm gonna do some more digging myself, but if you happen to see this and know the answer plz let me know. |
Fixes the knex query so that posts are correctly returned in the order of published_at, desc
closes #117 - Having immediately executable offloaded jobs is necessary to be able to run usecases like: send batched emails now, or any other job that does not need to be scheduled - Changed "simple" job timeout to make tests run faster
Published at and published by need to be set when the post status changes from draft to published. At the moment we are not able to tell if the status is changing now in the saving function.
I know this is a bookshelf issue (can/should the models have "changing" like in Backbone?) but hopefully you won't mind doing this when it's done.
The text was updated successfully, but these errors were encountered: