-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSS feed structure audit #2263
RSS feed structure audit #2263
Comments
For reference: http://www.rssboard.org/rss-specification |
http://dev.ghost.org/rss/2/ - should not be a thing. RSS feed = feed, not paginated. |
While I agree with JohnONolan that it feels a bit weird, both rss and atom seems to support it: http://tools.ietf.org/html/rfc5005#section-3 and http://www.ibm.com/developerworks/library/x-tipatom2/ One more thing that I found while coding on #2260, the rss feed doesn't seem to respect the admin setting for pagination but always use 15 as a page break. |
@stenehall Just because it exists doesn't mean it's right to do it :) The actual question is: Who subscribes to the second page (?) of an RSS feed? A thing that makes a lot more sense is a config option to define how many items should end up in the feed (or should it be tied to the number of posts on a page - which it probably should). There's no RSS reader that would pick up the second page of our RSS feeds - Feed readers check for new posts in the feed but never try to paginate (because there's no standard on how that would happen). |
@halfdan Totally agree. Just had to google it to read up a bit on it. I fully agree that it can be removed. |
@halfdan There are actually several people/tool that use the 2nd page (and further) when available. I'm thinking about import/export tools for example. But some traditional feed readers do that as well so they can serve "out of band" data to their users when they do searches for example. Now, I understand this is a rather "minor" feature. |
@julien51 How do feed readers know that there's a second page? For import/export we have the ugly debug tools - so it's easy to export your blog and import it somewhere else. |
@halfdan 2 ways:
And of course import/export with other tools, but in practice not all combination work well, and RSS is just a universal (yet often time lossy) way of achieving this. My memory fails me but IIRC a lot of Posterous importers where based on RSS because that just works =) But again, I understand (and agree) this is a very small subset of what RSS is used for. I just wanted to give my couple cents here and maybe leave that discussion open for a much later time when everything with a higher priority has been covered). |
After seeing #2332, I just wanted to put in my two cents and say that it appears to be vastly more common to use RSS feeds for summaries as opposed to full articles, especially since full articles can consume much more bandwidth in comparison to short summaries. Here are a few websites that show this example:
I could keep going, but I think this covers it rather well. |
Perhaps there could be an option in the settings or a secondary feed for those who do want full story feeds? |
@haneefmubarak options are the opposite of what Ghost is about. As expressed in #2332 (which would have been a more suitable place for your comment, btw) this is the kind of thing an App could/should do. |
#2777 is a valid issue with our current RSS implementation |
This audit has been open / pending for a while. Part of the problem we have is that there is no good alternative library for generating RSS feeds, and the existing one is broken in places and not very extensible. There has been talk of a new library in the works by @halfdan but I think it may be too much work. Wondering if there is a simpler solution, just using a .hbs template which contains XML? |
I've taken a brief look at this today, and identified a few things that we definitely need to (and also can quite easily) fix:
|
fixes TryGhost#5104, refs TryGhost#4348, TryGhost#2263 - Create a centralised event module - Hook it up for posts, pages, tags and users - Use it in sitemaps instead of direct method calls - Use it for xmlrpc calls - Check events are fired in model tests - Update sitemap tests to work with new code - Fix a bug where invited users were appearing in sitemaps - Move sitemaps and xmlrpc into a directory together
@amm4108 ah I see! Still it seems like it would be the wrong thing to do, to add those links making the pagination more discoverable when ultimately we plan to remove it as soon as the API becomes properly available? |
From #5065 (comment), @adrianmacneil said:
I have done a bit of research into this, looking at example fields, and it certainly appears to be the most widely supported way of including images in RSS. The reason it wasn't done this way in the original issue was because we weren't able to add custom elements to the feed + although being the most widely supported way, the Now that we are able to add custom elements & namespaces adding this is straightforward, however I think it needs to be added in addition to prepending the image to the |
Thanks @ErisDS, that solution works for us. We will be using the It's a shame feedly does not support the |
refs TryGhost#2263, TryGhost#4888 - Adds media:content element to Ghost Rt pSS feeds containing the post cover image if one is available - Removes the prepending of the image to the `<description>` field - Keeps the prepending of the image in `<content:encoded>`
refs TryGhost#2263, TryGhost#4888 - Adds media:content element to Ghost RSS feeds containing the post cover image if one is available - Removes the prepending of the image to the `<description>` field - Keeps the prepending of the image in `<content:encoded>`
refs TryGhost#5091, refs TryGhost#2263 - Move rss handling out of the frontend controller and into its own module - Separate the code into logical blocks - Wrap the generation code in a in-memory cache to prevent it being regenerated on every request
refs TryGhost#5091, refs TryGhost#2263 - Move rss handling out of the frontend controller and into its own module - Separate the code into logical blocks - Wrap the generation code in a in-memory cache to prevent it being regenerated on every request
refs TryGhost#5091, refs TryGhost#2263 - Move rss handling out of the frontend controller and into its own module - Separate the code into logical blocks - Wrap the generation code in a in-memory cache to prevent it being regenerated on every request
With the exception of With regard to I think this issue can be closed? |
@ericds Yes, this issue could be closed. (Too bad that summary feeds won't exist before the hypothetical release of Ghost Apps). |
Let's do a bit of an audit of Ghost RSS feeds vs WP RSS feeds, because there's quite a lot of difference at the moment. Eg.
http://john.onolan.org/rss/
vs
http://blog.kissmetrics.com/feed/
I'm fine with the two being different, but I'd like to make sure we're structuring feeds differently for the right (or at least some) reasons.
Are we using the correct tags? Are we missing any?
The text was updated successfully, but these errors were encountered: