Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing hrefs on <a> tags #3101

Closed
JohnONolan opened this issue Jun 25, 2014 · 3 comments · Fixed by #3277
Closed

Missing hrefs on <a> tags #3101

JohnONolan opened this issue Jun 25, 2014 · 3 comments · Fixed by #3277
Assignees
Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly

Comments

@JohnONolan
Copy link
Member

image

The post management settings cog has lost its href - which means the :hover state of the cursor no longer functions. It needs an href - even if it's just # + disabling the default functionality

Clarification: missing href removes browser default hover state. Eg. cursor:pointer

This is currently an issue in several places:

  • Post management settings cog
  • Editor settings cog
  • Global usermenu dropdown (also, I'm unable to right-click on this, why?)
  • The "delete" item in the post-settings menu
@JohnONolan JohnONolan added this to the 0.4 Ember.js milestone Jun 25, 2014
@JohnONolan JohnONolan changed the title Missing href on post management settings cog Missing hrefs on <a> tags Jun 25, 2014
@PaulAdamDavis
Copy link
Member

Related: #916

@novaugust
Copy link
Contributor

Looks like Ghost-UI got updated to add a cursor: pointer; prop to each of these? Is this closeable?

@PaulAdamDavis
Copy link
Member

The addition of cursor: pointer; was a poor attempt at a quick fix. Ideally, we want native hover events which bring the pointer cursor from the UA style sheet. What I did was pretty much brute-force.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants